Add logging on failure to create file #3424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 24, 2017
flovilmart
reviewed
Jan 24, 2017
| @@ -87,7 +88,8 @@ export class FilesRouter { | |||
| res.status(201); | |||
| res.set('Location', result.url); | |||
| res.json(result); | |||
| }).catch(() => { | |||
| }).catch((e) => { | |||
| logger.warn(e.message, e); | |||
acinader
force-pushed
the
add-logging-on-failure-to-filerouter
branch
from
e330775
to
4b69d47
Compare
|
@acinader updated the pull request - view changes |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're making some s3 changes and I was updating our config.
I did it wrong, and the create file failed. No big deal, but parse-server's response was a very unhelpful:
[object Object]output to console.error :(This change is local only to the FileRouter, which is necessary since we'll lose
ewhich has the important bit of info in it as to why the operation failed.....but i think we need a more global solution......