Skip to content

Conversation

@flovilmart
Copy link
Contributor

fixes #1311
may fix #1112

@codecov-io
Copy link

Current coverage is 92.80%

Merging #1424 into master will not affect coverage as of 75a4ca5

@@            master   #1424   diff @@
======================================
  Files           86      86       
  Stmts         5449    5460    +11
  Branches      1005    1007     +2
  Methods          0       0       
======================================
+ Hit           5057    5067    +10
  Partial         10      10       
- Missed         382     383     +1

Review entire Coverage Diff as of 75a4ca5

Powered by Codecov. Updated on successful CI builds.

}
return;
},
getRelationFields: function() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you leave this in by accident?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, we need it on the dummy schema otherwise the function is missing when running the tests

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah OK.

@flovilmart flovilmart merged commit a770c4c into master Apr 8, 2016
@drew-gross drew-gross deleted the fix-missing-relation branch April 8, 2016 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Relation fields is not retrieved Called relation() on non-relation field even when field is relation.

5 participants