fix: Bump ws from 8.20.0 to 8.21.0#10576
Conversation
|
🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review. Tip
Note Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect. Caution Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code. |
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
Important Review skippedNo new commits to review since the last review. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughChangesws dependency upgrade
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (1 error, 1 warning)
✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@package-lock.json`:
- Around line 20406-20426: Regenerate package-lock.json using the package
manager so the nested ws entries under parse and `@parse/push-adapter` resolve to
version 8.21.0, removing the stale 8.20.0 and 8.19.0 copies; do not manually
edit version or integrity fields.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: dfd033ce-c051-427f-acc6-8fee19f94de7
📒 Files selected for processing (2)
package-lock.jsonpackage.json
| "node_modules/parse/node_modules/ws": { | ||
| "version": "8.20.0", | ||
| "resolved": "https://registry.npmjs.org/ws/-/ws-8.20.0.tgz", | ||
| "integrity": "sha512-sAt8BhgNbzCtgGbt2OxmpuryO63ZoDk/sqaB/znQm94T4fCEsy/yV+7CdC1kJhOU9lboAEU7R3kquuycDoibVA==", | ||
| "license": "MIT", | ||
| "engines": { | ||
| "node": ">=10.0.0" | ||
| }, | ||
| "peerDependencies": { | ||
| "bufferutil": "^4.0.1", | ||
| "utf-8-validate": ">=5.0.2" | ||
| }, | ||
| "peerDependenciesMeta": { | ||
| "bufferutil": { | ||
| "optional": true | ||
| }, | ||
| "utf-8-validate": { | ||
| "optional": true | ||
| } | ||
| } | ||
| }, |
There was a problem hiding this comment.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
python - <<'PY'
import json
with open("package-lock.json", encoding="utf-8") as f:
lock = json.load(f)
found = []
def walk(value, path=()):
if isinstance(value, dict):
if path and path[-1] == "ws" and "version" in value:
found.append(("/".join(path), value["version"]))
for key, child in value.items():
walk(child, path + (key,))
elif isinstance(value, list):
for index, child in enumerate(value):
walk(child, path + (str(index),))
walk(lock)
for path, version in found:
print(f"{path}: {version}")
bad = [(path, version) for path, version in found if version != "8.21.0"]
if bad:
raise SystemExit("Unpatched ws entries remain")
PYRepository: parse-community/parse-server
Length of output: 382
🏁 Script executed:
#!/bin/bash
set -euo pipefail
python3 - <<'PY'
from pathlib import Path
path = Path("package-lock.json")
lines = path.read_text(encoding="utf-8").splitlines()
for start, end in [(20400, 20435), (40878, 40895)]:
print(f"\n--- lines {start}-{end} ---")
for i in range(start - 1, min(end, len(lines))):
print(f"{i+1}: {lines[i]}")
PYRepository: parse-community/parse-server
Length of output: 2477
🏁 Script executed:
#!/bin/bash
set -euo pipefail
python3 - <<'PY'
import json
from pathlib import Path
lock = json.loads(Path("package-lock.json").read_text(encoding="utf-8"))
def find_ws_entries(value, path=()):
if isinstance(value, dict):
if path and path[-1] == "ws" and "version" in value:
yield (path, value)
for k, v in value.items():
yield from find_ws_entries(v, path + (k,))
elif isinstance(value, list):
for i, v in enumerate(value):
yield from find_ws_entries(v, path + (str(i),))
for path, entry in find_ws_entries(lock):
if entry.get("version") in {"8.19.0", "8.20.0", "8.21.0"}:
print("/".join(path), entry.get("version"), entry.get("resolved"))
PYRepository: parse-community/parse-server
Length of output: 425
Remove the stale nested ws copies. package-lock.json still pins dependencies/parse/dependencies/ws to 8.20.0 and dependencies/@parse/push-adapter/dependencies/ws to 8.19.0; regenerate the lockfile so both resolve to 8.21.0 instead of patching integrity fields by hand.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@package-lock.json` around lines 20406 - 20426, Regenerate package-lock.json
using the package manager so the nested ws entries under parse and
`@parse/push-adapter` resolve to version 8.21.0, removing the stale 8.20.0 and
8.19.0 copies; do not manually edit version or integrity fields.
1 participant
Closes #10509
Replaces the Dependabot PR with a
fix:release-triggering security update.wsis a direct production dependency.Changes
wsfrom 8.20.0 to 8.21.0.Breaking Changes
None
Code Changes Required
None — the upgrade is a drop-in replacement (manifest + lock file only).
Summary by CodeRabbit