Skip to content

Conversation

@mtrezza
Copy link
Member

@mtrezza mtrezza commented Feb 6, 2026

Pull Request

Issue

Default HTML pages for password reset, email verification not found.

Summary by CodeRabbit

  • New Features

    • Added support for custom pages endpoints and route configuration
    • Added ability to customize URLs for password reset and email verification flows
  • Documentation

    • Clarified that the default pages directory is the ./public/ directory of the Parse Server module

@parse-github-assistant
Copy link

🚀 Thanks for opening this pull request!

@parseplatformorg
Copy link
Contributor

parseplatformorg commented Feb 6, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@coderabbitai
Copy link

coderabbitai bot commented Feb 6, 2026

📝 Walkthrough

Walkthrough

The changes remove the automatic default assignment for pagesPath in the Pages configuration, making it undefined by default. New public interfaces for custom URLs and routes are added to the Pages options. Tests are updated to reflect the new behavior and verify pages work regardless of working directory.

Changes

Cohort / File(s) Summary
Configuration & Validation
src/Config.js, src/Options/Definitions.js, src/Options/docs.js
Modified pagesPath handling to remove default assignment, making it undefined when not explicitly set. Updated validation logic and documentation to reflect that the default is the ./public/ directory of the parse-server module.
Options & Type Definitions
src/Options/index.js
Added new public interface properties to PagesOptions: pagesEndpoint, customUrls, and customRoutes. Introduced new type definitions: PagesRoute, PagesCustomUrlsOptions, and CustomPagesOptions for configuring custom URLs and routes in the Pages feature.
Tests
spec/PagesRouter.spec.js
Updated test expectation for default pagesPath config to assert undefined instead of a default value. Added new test suite "pagesPath resolution" to verify pages work when process working directory differs from module directory, with test duplication present.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is largely incomplete. Only the Issue section is minimally filled with a brief statement, while the Approach and Tasks sections are entirely missing. Complete the Approach section explaining the changes made to fix the issue, and fill out the Tasks checklist indicating which items were completed for this PR.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main issue being fixed: default HTML pages for password reset and email verification are not found.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.53%. Comparing base (c1f1800) to head (673cd27).
⚠️ Report is 2 commits behind head on alpha.

Additional details and impacted files
@@            Coverage Diff             @@
##            alpha   #10041      +/-   ##
==========================================
- Coverage   92.53%   92.53%   -0.01%     
==========================================
  Files         190      190              
  Lines       15523    15521       -2     
  Branches      176      176              
==========================================
- Hits        14364    14362       -2     
  Misses       1147     1147              
  Partials       12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mtrezza mtrezza merged commit a4265bb into parse-community:alpha Feb 6, 2026
21 of 23 checks passed
parseplatformorg pushed a commit that referenced this pull request Feb 6, 2026
# [9.3.0-alpha.2](9.3.0-alpha.1...9.3.0-alpha.2) (2026-02-06)

### Bug Fixes

* Default HTML pages for password reset, email verification not found ([#10041](#10041)) ([a4265bb](a4265bb))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 9.3.0-alpha.2

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Feb 6, 2026
@mtrezza mtrezza deleted the fix/default-pages-404 branch February 7, 2026 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:released-alpha Released as alpha version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

requestPasswordReset email link (“Verify Email” button) redirects to Not Found

2 participants