Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a comment field in queries #8799

Closed
oallouch opened this issue Nov 1, 2023 · 10 comments · Fixed by #8928 or #9015
Closed

Add a comment field in queries #8799

oallouch opened this issue Nov 1, 2023 · 10 comments · Fixed by #8928 or #9015
Labels
bounty:$50 Bounty applies for fixing this issue (Parse Bounty Program) state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version type:feature New feature or improvement of existing feature

Comments

@oallouch
Copy link
Contributor

oallouch commented Nov 1, 2023

Hi,

For my clients, I monitor their MongoDB Atlas cluster using the Profiler, which shows a graph of all slow queries.
When I see a slow query, it's hard for me to know where it comes from, in the codebase. We have many coders in many projects that all use the Parse JS SDK.
MongoDB query options have a comment field.
It would be great to have it in Parse.

Thx

Olivier

Copy link

Thanks for opening this issue!

@mtrezza
Copy link
Member

mtrezza commented Nov 2, 2023

I assume you mean $comment?

Seems like a useful feature, could be implemented like:

const query = new Parse.Query('Test');
query.comment('...');

For the aggregation pipeline this should be already supported.
For the Parse JS SDK this requires changes in Parse Server and the Parse JS SDK.

@mtrezza mtrezza added type:feature New feature or improvement of existing feature bounty:$50 Bounty applies for fixing this issue (Parse Bounty Program) labels Nov 2, 2023
@oallouch
Copy link
Contributor Author

oallouch commented Nov 2, 2023

It could be coded by taking 'hint' as an example.

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.0.0-alpha.23

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Mar 3, 2024
@mtrezza mtrezza reopened this Mar 11, 2024
@mtrezza
Copy link
Member

mtrezza commented Mar 11, 2024

@Meglali20 Could you please take a look at the tests in #8928? After merging, it seems that the tests are flaky, see for example https://github.com/parse-community/parse-server/actions/runs/8238148925/job/22528520534. It's not just that one test, but various comment related tests, so it seems to be a general issue with the test structure. Maybe you need to await something, or add a delay somewhere if await is not possible. It could of course also be an issue with the feature itself, but flakiness is usually a testing issue.

@Meglali20
Copy link
Contributor

Meglali20 commented Mar 12, 2024

When you said various comment related tests are failing, can you confirm whether all tests are failing or only one test fails and the other succeeds?

@mtrezza
Copy link
Member

mtrezza commented Mar 12, 2024

Different comment relates tests were failing, sometimes the comment with count, sometimes other ones. It just seems flaky, see the links.

@Meglali20
Copy link
Contributor

Meglali20 commented Mar 12, 2024

I checked the failing workflows and I can see that only one test fails at a time, I think it's because of the profiler not being enabled correctly, I will make a PR with updated tests.

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Mar 19, 2024
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty:$50 Bounty applies for fixing this issue (Parse Bounty Program) state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version type:feature New feature or improvement of existing feature
Projects
None yet
4 participants