Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing deprecation of non-array list for keys and excludeKeys #7719

Open
4 tasks done
mtrezza opened this issue Nov 26, 2021 · 3 comments
Open
4 tasks done

Missing deprecation of non-array list for keys and excludeKeys #7719

mtrezza opened this issue Nov 26, 2021 · 3 comments
Labels
type:bug Impaired feature or lacking behavior that is likely assumed

Comments

@mtrezza
Copy link
Member

mtrezza commented Nov 26, 2021

New Issue Checklist

Issue Description

Issue #7245 deprecated comma separated string lists in favor of arrays, starting with Parse Server 5. The deprecation however is not implemented in code (via runtime deprecation) and documented in the deprecation table.

In order remove the deprecation in the future, as per policy it has to be officially communicated for a full major release (1 year). If the deprecation is officially added before Parse Server 5 release, the removal can happen earliest with Parse Server 6 (2023).

Steps to reproduce

n/a

Actual Outcome

n/a

Expected Outcome

n/a

Environment

n/a

Logs

n/a

@parse-github-assistant
Copy link

Thanks for opening this issue!

  • 🚀 You can help us to fix this issue faster by opening a pull request with a failing test. See our Contribution Guide for how to make a pull request, or read our New Contributor's Guide if this is your first time contributing.

@mtrezza mtrezza added severity:low type:bug Impaired feature or lacking behavior that is likely assumed labels Nov 26, 2021
@cbaker6
Copy link
Contributor

cbaker6 commented Nov 26, 2021

I didn’t design the 7245 to deprecate a comma separated string because most of the client sdk’s are designed to that flaw. Instead, I designed the PR to work with an array of strings and the comma separated string which is why the documentation and my comments in the PR are written the way they are (also why I kept all of the old tests).

Deprecating will require PR’s in every client SDK in the future (except for the Swift SDK, I never designed it to work with the flaw) and essentially make newer versions of the respective SDKs not backwards compatible with servers <5.0.0. In the current state after my PR, all SDKs are backwards and forwards comparable. I suspect you will cause more harm than good by deprecating and it will probably be easier to keep both.

@mtrezza
Copy link
Member Author

mtrezza commented Nov 26, 2021

So we only deprecate the string once all SDKs are changed. I will flag this as "on hold". Unless there is another good reason to support strings in addition to arrays indefinitely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Impaired feature or lacking behavior that is likely assumed
Projects
None yet
Development

No branches or pull requests

2 participants