Upload files in folder with S3 adapter

[Klaitos]

Hello,

I know that uploading a file on a specific folder with S3 file adapter is not correctly/fully handled with Parse.Server. I've read that all files are uploaded at the same bucket level.

However, i've uploaded a file manually in a folder in a S3 bucket. Example bucket>folder>myfile.png.
I have set with Mongo manually a parse file field on my object. (MyObject.picture = "folder/myfile.png"
When i'm trying to view this file from the file controller it doesn't works correctly.

http://localhost:1337/api/files/local_app_id/folder/myfile.png -> doesn't work :
{ "error": "unauthorized" }
http://localhost:1337/api/files/local_app_id/folder%2Fmyfile.png
It works !

Do you know how can I fix this or am i missing something ?

Thanks a lot

[dplewis]

Which version of the Server are you running?

[Klaitos]

Which version of the Server are you running?

4.1.0

[dplewis]

Can you try to debug it to ensure the filename is passed in correctly?

https://github.com/parse-community/parse-server/blob/master/src/Routers/FilesRouter.js#L12

@mpatnode Can you look into this? You know more about this than I do. 😅

[mpatnode]

I'll take a peek tomorrow.

[Klaitos]

I've tried some things.
Assuming the following asset url : http://localhost:1337/api/files/local_app_id/folder/test.jpg
With current file controller listening for the pattern : /files/:appId/:filename i'm not getting through the controller method.
Replacing with /files/:appId/:filename(*), here are the output of params :
{ '0': 'folder/test.jpg', appId: 'local_app_id', filename: 'folder/test.jpg' }

I'm not fully aware of side effects

[mman]

This will also affect #6344, since beforeSave trigger on file can actually change a filename before saving the file, which could be used to store a given file in a subdirectory. Modifying the route match as pointed out by @Klaitos would be a good idea IMHO.

[mpatnode]

So I dropped a comment in on #6344. Think we're in trouble if the filename changes in one of those hooks. In my app, I'm serving the actually files directly from S3 via cloudfront (with a Lambda image cutter) so I never mucked with the files pattern matcher.

[Sanitha-11224]

Did you get the answer? Pls share the idea for how will be create the sub folder ?