Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to use async requests on choose password #5418

Closed
vince1995 opened this issue Mar 13, 2019 · 2 comments
Closed

Add possibility to use async requests on choose password #5418

vince1995 opened this issue Mar 13, 2019 · 2 comments

Comments

@vince1995
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Because JavaScript must be available in choose_password the form which redirects to another page seems needless.

Describe the solution you'd like
To uphold backwards compatibility add a simple flag shouldNotRedirect to the body of the POST request and just respond with the status code 200 instead of 302.

Describe alternatives you've considered
I'm using a custom page and proxying the request to keep a SPA instead of getting an unneeded redirect (which causes a full refresh of my website).

@dplewis
Copy link
Member

dplewis commented Mar 14, 2019

@vince1995 A PR #5332 was submitted. Would something like this help?

@vince1995
Copy link
Contributor Author

Oh wow, yeah, that's exactly what I imagined. Sorry, searched in issues for that feature but not in PRs. You can close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants