Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checkResetTokenValidity throws undefined #4267

Closed
oallouch opened this issue Oct 19, 2017 · 2 comments
Closed

checkResetTokenValidity throws undefined #4267

oallouch opened this issue Oct 19, 2017 · 2 comments

Comments

@oallouch
Copy link
Contributor

Hi,
The errors thrown from checkResetTokenValidity are undefined or lack codes (see UserController.js line 78).
That makes error treatment quite difficult.

Olivier
@flovilmart
Copy link
Contributor

If the error is undefined, it means that no link exists, if the error is 'The password reset link has expired'. Errors could be indeed improved. Do you wanna work on a PR for that?

@dplewis
Copy link
Member

dplewis commented Apr 3, 2019

Closing via #5332

@dplewis dplewis closed this as completed Apr 3, 2019
@snyk-bot snyk-bot mentioned this issue Jul 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@flovilmart @oallouch @montymxb @dplewis