Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] Select fields does not propagate to the Mongo Layer #2653

Closed
shivangagarwal opened this issue Sep 6, 2016 · 2 comments
Closed
Milestone

Comments

@shivangagarwal
Copy link

Hi,

Is there a specific reason as to why the select fields are not propagated to the Database Controller layer and further passed on to Mongo? Currently all the fields are fetched from Mongo and then sliced at the parse-server level, but we can just pass the select fields to the Mongo itself. By adding these changes, the queries are much much faster.

Let me know if i am missing something. If this is fine, i can provide with a PR.

@shivangagarwal shivangagarwal changed the title [Discussion] Select does not propagate to the Mongo Layer [Discussion] Select fields does not propagate to the Mongo Layer Sep 6, 2016
@flovilmart
Copy link
Contributor

No specific reason. Go ahead! I believe you can also do the same for $dontSelect.

Just one note, we're trying to move forward with the PG adapter as well, so that change should be also propagated to the PG adapter.

@flovilmart
Copy link
Contributor

Closing has it's been merged to master and released to 2.2.22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants