Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #68

Merged
merged 2 commits into from
Jul 15, 2019
Merged

Fix tests #68

merged 2 commits into from
Jul 15, 2019

Conversation

davimacedo
Copy link
Member

This PR adds a fake aws sdk for running unit tests when the aws credentials are not available (for instance, in travis).

It is a very simple fake adapter, but if needed, later, we can keep improving it to simulate real issues.

Tests with the real aws sdk can still be done locally by setting up the TEST_S3_ACCESS_KEY, TEST_S3_SECRET_KEY, and TEST_S3_BUCKET env vars.

Close #67

@codecov
Copy link

codecov bot commented Jul 13, 2019

Codecov Report

Merging #68 into master will increase coverage by 22.91%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #68       +/-   ##
===========================================
+ Coverage   70.83%   93.75%   +22.91%     
===========================================
  Files           2        2               
  Lines         144      144               
  Branches       31       31               
===========================================
+ Hits          102      135       +33     
+ Misses         42        9       -33
Impacted Files Coverage Δ
index.js 92.2% <0%> (+42.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 738bea2...f069c49. Read the comment docs.

@davimacedo davimacedo mentioned this pull request Jul 13, 2019
@davimacedo davimacedo requested a review from acinader July 13, 2019 00:19
@acinader acinader merged commit ae5b744 into parse-community:master Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests are failing
2 participants