Remove NodeCommand for AWS

[dblythy]

Related to issue #373.

It seems as though AWS no longer supports NoeCommand, and running a fresh example install throws "NodeCommand not found".

Not sure if this has any impact on previous deployments on AWS.

[mtrezza]

@TomWFox, @acinader who has write rights to review this?

[TomWFox]

Feel free to add a review but @davimacedo & @dplewis have access (as do I).

[mtrezza]

running a fresh example install throws "NodeCommand not found".

Interesting, I do not observe that, I see it deploy and run as expected. However, it seems to be indeed a legacy option.

Not sure if this has any impact on previous deployments on AWS.

It should not have any implications, as the docs say:

You can add a Procfile to your source bundle to specify the command that starts your application, as the following example shows. This feature replaces the legacy NodeCommand option in the aws:elasticbeanstalk:container:nodejs namespace. When you don't provide a Procfile, Elastic Beanstalk runs npm start if you provide a package.json file. If you don't provide that either, Elastic Beanstalk looks for the file app.js or server.js, in this order, and runs it.

I also tested this with an existing deployment of parse server example and the EB app updates as expected.

Related to this community discussion

@TomWFox Can we add the "issue" tab in this repo? I feel that linking PRs to threads in the Community Forum is generally not good practice, as we may loose the info there. The link above for example does not work, the correct link is this. Link didn't work before for some reason.

Related AWS doc.

[TomWFox]

Issues turned on - I see why they were turned off - could do with closing some issues. I corrected the link.

[mtrezza]

could do with closing some issues

You can add me to the repo and I'll clean it up.

[TomWFox]

Done, 105 -> 1 all but the remaining were 3+ years old (obviously inactive) and many seemed to be issues that should have been created on the Parse Server repo.

[TomWFox]

@mtrezza I’ve added this repo to the Server team so you should have write access now.

[mtrezza]

Thanks Tom, reviewed it and LGTM.

[mtrezza]

Tested with AWS EB deployment and works, LGTM.

[parseplatformorg]

🎉 This change has been released in version 1.2.0