Skip to content

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented May 10, 2023

New Pull Request Checklist

Approach

  • Document Helper::print. PHPUnit doesn't allow echo, var_dump, print_r to output to STDOUT
  • Remove unused links
  • Remove unused cloud code folder
  • Add Code of Conduct

TODOs before merging

  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link

parse-github-assistant bot commented May 10, 2023

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a0957c1) 98.48% compared to head (f6de82c) 98.48%.

❗ Current head f6de82c differs from pull request most recent head 6491f5e. Consider uploading reports for the commit 6491f5e to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #508   +/-   ##
=========================================
  Coverage     98.48%   98.48%           
  Complexity     1060     1060           
=========================================
  Files            38       38           
  Lines          3225     3225           
=========================================
  Hits           3176     3176           
  Misses           49       49           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dplewis dplewis requested a review from mtrezza May 10, 2023 17:15
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, is this ready for merge?

@mtrezza mtrezza changed the title refactor: Improve Contributing Guide docs: Improve Contributing Guide May 10, 2023
@mtrezza mtrezza merged commit a269f9e into parse-community:master May 10, 2023
@dplewis dplewis deleted the refactor-contribution branch May 12, 2023 18:37
@parseplatformorg
Copy link

🎉 This change has been released in version 2.2.0

@parseplatformorg parseplatformorg added the state:released Released as stable version Edit label May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:released Released as stable version Edit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants