Skip to content

Issue: Don't make Everyone the default audience on Push #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2018
Merged

Issue: Don't make Everyone the default audience on Push #910

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/dashboard/Push/PushNew.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ class PushNew extends DashboardView {
this.state = {
pushAudiencesFetched: false,
deviceCount: null,
initialAudienceId: 'everyone',
initialAudienceId: null,
audienceSizeSuggestion: null,
recipientCount: null,
isLocalizationAvailable: false,
Expand Down Expand Up @@ -632,7 +632,7 @@ class PushNew extends DashboardView {
pushAudiencesStore={this.props.pushaudiences}
current={fields.audience_id}
onChange={(audienceId, queryOrFilters, deviceCount) => {
this.setState({ deviceCount });
this.setState({ deviceCount, audienceId });
setField('audience_id', audienceId);
if (audienceId === PushConstants.NEW_SEGMENT_ID) {
// Horrible code here is due to old rails code that sent pushes through it's own endpoint, while Parse Server sends through Parse.Push.
Expand Down Expand Up @@ -727,6 +727,11 @@ class PushNew extends DashboardView {
valid(changes) {
let emptyInputMessages = [];
let invalidInputMessages = [];

if (!this.state.audienceId) {
emptyInputMessages.push('you need select an audience');
}

// when number audience size is 0
if (this.state.deviceCount === 0) {
emptyInputMessages.push('recipient count for this campaign');
Expand Down