Make clickHandler registration more clear #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Declares a `hasOnClick` variable to make the ternary expression returning the `clickHandler` value shorter and more clear * Creates a `noop` function outside the component function so that the component doesn't have to create a new function every time new props are passed.
|
By analyzing the blame information on this pull request, we identified @drew-gross to be a potential reviewer. |
drew-gross
added a commit
that referenced
this pull request
Mar 6, 2016
Make clickHandler registration more clear
douglasmuraoka
pushed a commit
that referenced
this pull request
Nov 29, 2019
Improve analytics features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hasOnClickvariable to make the ternary expression returning theclickHandlervalue shorter and more clearnoopfunction outside the component function so that the component doesn't have to create a new function every time new props are passed.