Skip to content

Conversation

@scthi
Copy link
Contributor

@scthi scthi commented Feb 6, 2017

The apps list in src/dashboard/Apps/AppsIndex.react.js is sorted by name now (asc).

It was sorted by the createdAt attribute.

@natanrolnik
Copy link
Contributor

natanrolnik commented Feb 6, 2017

@scthi thanks for your contribution. I've noticed that AppsManager already returns apps() sorted by name. You can check it here. In your dashboard, your apps are not sorted?

@facebook-github-bot
Copy link

@scthi updated the pull request - view changes

@scthi
Copy link
Contributor Author

scthi commented Feb 6, 2017

@natanrolnik Thanks for the hint. That makes my PR even simpler... :-)

@natanrolnik
Copy link
Contributor

Looks good to me. Maybe @steven-supersolid wants to take a look also?

@natanrolnik natanrolnik merged commit 59c18b1 into parse-community:master Feb 6, 2017
@scthi
Copy link
Contributor Author

scthi commented Feb 6, 2017

Thx guys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants