Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove pre-selected key from filter field in data browser #2590

Open
wants to merge 2 commits into
base: alpha
Choose a base branch
from

Conversation

Clayton1805
Copy link

@Clayton1805 Clayton1805 commented Sep 7, 2024

New Pull Request Checklist

Issue Description

Closes: #2478

Approach

Remove the field recommendation for the filter, introduce a list of draft filters that replaces the recommendation, and the new lines are automatically focused.

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)

Copy link

parse-github-assistant bot commented Sep 7, 2024

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

Copy link

uffizzi-cloud bot commented Sep 7, 2024

Uffizzi Ephemeral Environment deployment-55993

⌚ Updated Sep 07, 2024, 03:35 UTC

☁️ https://app.uffizzi.com/github.com/parse-community/parse-dashboard/pull/2590

📄 View Application Logs etc.

What is Uffizzi? Learn more

@Clayton1805 Clayton1805 closed this Sep 7, 2024
@Clayton1805 Clayton1805 reopened this Sep 7, 2024
@Clayton1805 Clayton1805 marked this pull request as draft September 7, 2024 22:51
Copy link

uffizzi-cloud bot commented Sep 7, 2024

Uffizzi Ephemeral Environment deployment-55999

⌚ Updated Sep 07, 2024, 22:57 UTC

☁️ https://app.uffizzi.com/github.com/parse-community/parse-dashboard/pull/2590

📄 View Application Logs etc.

What is Uffizzi? Learn more

@Clayton1805 Clayton1805 marked this pull request as ready for review September 7, 2024 22:59
@Clayton1805 Clayton1805 changed the title remove pre-selected key from filter fields feat: remove pre-selected key from filter fields Sep 7, 2024
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title feat: remove pre-selected key from filter fields feat: Remove pre-selected key from filter fields Sep 7, 2024
@mtrezza mtrezza changed the title feat: Remove pre-selected key from filter fields feat: Remove pre-selected key from filter field in data browser Sep 16, 2024
@mtrezza mtrezza closed this Sep 16, 2024
@mtrezza mtrezza reopened this Sep 16, 2024
Copy link

uffizzi-cloud bot commented Sep 16, 2024

Uffizzi Ephemeral Environment deployment-56292

⌚ Updated Sep 16, 2024, 01:54 UTC

☁️ https://app.uffizzi.com/github.com/parse-community/parse-dashboard/pull/2590

📄 View Application Logs etc.

What is Uffizzi? Learn more

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some issues:

  • Drop down list does not close when clicking on other field.

    Screen.Recording.2024-09-16.at.12.35.57.mov
  • When adding multiple empty conditions, setting a field on a condition sets it on the first empty condition instead of the condition in which it is set.

    Screen.Recording.2024-09-16.at.12.36.25.mov
  • Adding a field does not it in the field drop down, dashboards needs to be reloaded in browser for field to show up.

    Screen.Recording.2024-09-16.at.12.44.13.mov

@mtrezza
Copy link
Member

mtrezza commented Sep 24, 2024

@Clayton1805 Just a ping in case you missed the feedback above. If you could take a look at these when you find some time...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve filer dialog auto-complete usability
2 participants