-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remove pre-selected key from filter field in data browser #2590
base: alpha
Are you sure you want to change the base?
feat: Remove pre-selected key from filter field in data browser #2590
Conversation
Thanks for opening this pull request!
|
Uffizzi Ephemeral Environment
|
cc277ba
to
d4fa058
Compare
Uffizzi Ephemeral Environment
|
I will reformat the title to use the proper commit message syntax. |
Uffizzi Ephemeral Environment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found some issues:
-
Drop down list does not close when clicking on other field.
Screen.Recording.2024-09-16.at.12.35.57.mov
-
When adding multiple empty conditions, setting a field on a condition sets it on the first empty condition instead of the condition in which it is set.
Screen.Recording.2024-09-16.at.12.36.25.mov
-
Adding a field does not it in the field drop down, dashboards needs to be reloaded in browser for field to show up.
Screen.Recording.2024-09-16.at.12.44.13.mov
@Clayton1805 Just a ping in case you missed the feedback above. If you could take a look at these when you find some time... |
New Pull Request Checklist
Issue Description
Closes: #2478
Approach
Remove the field recommendation for the filter, introduce a list of draft filters that replaces the recommendation, and the new lines are automatically focused.
TODOs before merging