-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow to set a custom host #224
Conversation
By analyzing the blame information on this pull request, we identified @drew-gross, @hallucinogen and @gimdongwoo to be potential reviewers. |
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
I think host is misleading for the beginners as this refers to the bound IP address. Also, no need to update the address in the README. Locallhost will still be working fine. Not sure 0.0.0.0 will as this represents nothing much for the local machine |
Thanks for your answer. Sure. Any suggestion? What about I don't see why |
It's just that when people will see: Dashboard running on 'http://0.0.0.0/dashboard' they will paste that on their web browser and won't be able to access it |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
ok then, but know that 0.0.0.0 don't mean localhost... |
👍 And for the |
we can stick with host, @peterdotjs what do you think? |
I also prefer |
Fixes #222