Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to set a custom host #224

Merged
merged 1 commit into from
Apr 5, 2016
Merged

allow to set a custom host #224

merged 1 commit into from
Apr 5, 2016

Conversation

hpello
Copy link
Contributor

@hpello hpello commented Apr 4, 2016

Fixes #222

@facebook-github-bot
Copy link

By analyzing the blame information on this pull request, we identified @drew-gross, @hallucinogen and @gimdongwoo to be potential reviewers.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@flovilmart
Copy link
Contributor

I think host is misleading for the beginners as this refers to the bound IP address.

Also, no need to update the address in the README. Locallhost will still be working fine. Not sure 0.0.0.0 will as this represents nothing much for the local machine

@hpello
Copy link
Contributor Author

hpello commented Apr 4, 2016

Thanks for your answer.

Sure. Any suggestion? What about --address and ADDRESS then?

I don't see why 0.0.0.0 would not be working on the local machine? I had changed the address in the README (as well as in the console.log message) in order not to confuse users, who could think their dashboard is not accessible from the outside (localhost) when it actually is (0.0.0.0).
But I'll leave localhost if you prefer.

@flovilmart
Copy link
Contributor

It's just that when people will see: Dashboard running on 'http://0.0.0.0/dashboard' they will paste that on their web browser and won't be able to access it

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@hpello
Copy link
Contributor Author

hpello commented Apr 5, 2016

Well, with the current version 1.0.7, it works well for me on Firefox and Chrome :
screen shot 2016-04-05 at 15 48 21

@flovilmart
Copy link
Contributor

ok then, but know that 0.0.0.0 don't mean localhost...

@hpello
Copy link
Contributor Author

hpello commented Apr 5, 2016

👍

And for the adress/host flag and env var?
I liked the host one, as it will work with any host, such as localhost, 192.168.1.16 or mywebsite.com, but I'm fine with anything you guys would like.

@flovilmart
Copy link
Contributor

we can stick with host, @peterdotjs what do you think?

@drew-gross
Copy link
Contributor

I also prefer localhost but I'm just going to merge this and then update the docs.

@drew-gross drew-gross merged commit ac33bc7 into parse-community:master Apr 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants