fix: Update base config to work with sass-loader 8.x #1258
Conversation
| @@ -120,7 +120,7 @@ | |||
| "parse-dashboard": "./bin/parse-dashboard" | |||
| }, | |||
| "engines": { | |||
| "node": ">=4.3" | |||
| "node": ">=8.9" | |||
There was a problem hiding this comment.
We have some dependencies that require at least node 8.x, as Parse-Server. Besides that, sass-loader announced a breaking change in the changelog about minimum required node version.
There was a problem hiding this comment.
Yes, I'm good with it. Node 8 is at 8.16 and it goes out of maintenance in a few months at which point I think we set the minimum at 10 and should be testing everything against 12 too!
More broadly (and to invite criticism), I think that when considering node versions for all of our node repositories (and parse-dashboard in particular), we should not bend over backward to support obsolete versions like early node 8 versions.
Users don't have to upgrade to newer versions of parse if they are unwilling to keep up with dependencies.
I suspect that this is a non-issue. Would we then want to make the next release 2.0.0? I think to comply with semantic versioning we should??? For some reason, I'm stingy with those version numbers ;).
There was a problem hiding this comment.
I agree. Let's go to Parse Dashboard 2.0 then.
There was a problem hiding this comment.
@alencarlucas Thanks for tackling this! I have one question.
* chore(package): update sass-loader to version 8.0.0 * chore(package): update lockfile package-lock.json * fix: Update base config to work with sass-loader 8.x (#1258)
Source