-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue regarding lost mount path #1070
Conversation
Can be tested by changing mountpath in [index.js](https://github.com/parse-community/parse-dashboard/blob/master/Parse-Dashboard/index.js#L35)
@acinader How does this look? That TODO is a reminder for future e2e tests. I’d recommend giving it a shot when you have time. I ran into a few issues when I tried to mount a parse server. |
@dplewis I've taken a first (second and third) pass at testing and I have run into problems. I don't know if it is because of this change combined with how I run the dashboard or if it is my unfamiliarity with how to test the dashboard. I suspect the later. Here's my setup: I have a repo with package.json that includes the dependency: The package.json has this script:
When I try to change the dependency from I get a blank white page with following js error in the console: if I click through to login.bundle.js in the inspector, they look very different, so I suspect the issue is that I don't know how to test a branch and build it, etc. I'll give it another try in a few hours when I have some time to look into it. |
ahh, much better! thanks. works like a charm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one super nit. nice on the test!!
.gitignore
Outdated
@@ -11,3 +11,6 @@ npm-debug.log | |||
*.swp | |||
.env | |||
.idea/ | |||
|
|||
logs/ | |||
test_logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add trailing cr
ps: thanks for spoon feeding me. much appreciated... |
@larcoamir I've noticed you've left several comments on years old threads. Your chances to receive support this way are rather slim as we use GitHub only for code related issues, not for support. For help with Parse Platform we recommend our community forum. |
Can be tested by setting process.env.MOUNT_PATH.
Test Added