Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue regarding lost mount path #1070

Merged
merged 6 commits into from
May 3, 2019
Merged

Fix issue regarding lost mount path #1070

merged 6 commits into from
May 3, 2019

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented May 2, 2019

Can be tested by setting process.env.MOUNT_PATH.

Test Added

@dplewis dplewis requested a review from acinader May 3, 2019 02:57
@dplewis
Copy link
Member Author

dplewis commented May 3, 2019

@acinader How does this look? That TODO is a reminder for future e2e tests.

I’d recommend giving it a shot when you have time. I ran into a few issues when I tried to mount a parse server.

@acinader
Copy link
Contributor

acinader commented May 3, 2019

@dplewis I've taken a first (second and third) pass at testing and I have run into problems. I don't know if it is because of this change combined with how I run the dashboard or if it is my unfamiliarity with how to test the dashboard. I suspect the later.

Here's my setup:

I have a repo with package.json that includes the dependency: parse-dashboard: latest. I have a parse-dashboard-config.json file that has entries for all my pars servers.

The package.json has this script:

"start": "parse-dashboard --config parse-dashboard-config.json",

When I try to change the dependency from latest to github:parse-community/parse-dashboard#mount-fix

I get a blank white page with following js error in the console: Uncaught SyntaxError: Unexpected token <

if I click through to login.bundle.js in the inspector, they look very different, so I suspect the issue is that I don't know how to test a branch and build it, etc.

I'll give it another try in a few hours when I have some time to look into it.

@dplewis
Copy link
Member Author

dplewis commented May 3, 2019

@acinader There is a known issue with that #1049 I fixed that in my last commit try to install from branch again.

@acinader
Copy link
Contributor

acinader commented May 3, 2019

ahh, much better! thanks.

works like a charm.

Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one super nit. nice on the test!!

.gitignore Outdated
@@ -11,3 +11,6 @@ npm-debug.log
*.swp
.env
.idea/

logs/
test_logs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add trailing cr

@acinader
Copy link
Contributor

acinader commented May 3, 2019

ps: thanks for spoon feeding me. much appreciated...

@larcoamir
Copy link

@acinader There is a known issue with that #1049 I fixed that in my last commit try to install from branch again.

Could please you suggest me git commands to install from the branch?

@mtrezza
Copy link
Member

mtrezza commented May 7, 2022

@larcoamir I've noticed you've left several comments on years old threads. Your chances to receive support this way are rather slim as we use GitHub only for code related issues, not for support. For help with Parse Platform we recommend our community forum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants