Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload Cloud Config param before updating #2567

Open
3 tasks done
mtrezza opened this issue May 21, 2024 · 1 comment
Open
3 tasks done

Reload Cloud Config param before updating #2567

mtrezza opened this issue May 21, 2024 · 1 comment
Labels
bounty:$20 Bounty applies for fixing this issue (Parse Bounty Program) type:feature New feature or improvement of existing feature

Comments

@mtrezza
Copy link
Member

mtrezza commented May 21, 2024

New Feature / Enhancement Checklist

Current Limitation

When updating the value of a Cloud Config param, the value may have been updated between the time of loading the Cloud Config page and the time of sending the update to the server. This causes any updates made within that timespan to be overwritten.

Feature / Enhancement Description

Before updating a Cloud Config param reload the current value from the server and compare it with the previous value that will be overwritten. If the current value provided by the sever is different than the previous value stored locally by the dashboard, then show a warning message that changes will be overwritten.

This doesn't prevent edge cases like a race condition, in which a value change occurs between the dashboard fetching the current value from server and sending the updated value to the server. This is really on possible with atomic updates.

Example Use Case

  1. Bowser window 1: Open dashboard, navigate to Cloud Config page.
  2. Bowser window 2: Open dashboard, navigate to Cloud Config page.
  3. Bowser window 2: Edit a param and save it.
  4. Bowser window 1: Edit the same param and save it --> should display warning, as browser window 1 already updated value.
Copy link

Thanks for opening this issue!

  • 🎉 We are excited about your ideas for improvement!

@mtrezza mtrezza added bounty:$20 Bounty applies for fixing this issue (Parse Bounty Program) type:feature New feature or improvement of existing feature labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty:$20 Bounty applies for fixing this issue (Parse Bounty Program) type:feature New feature or improvement of existing feature
Projects
None yet
Development

No branches or pull requests

1 participant