Skip to content

Optimize review process #1848

Closed
Closed
@mtrezza

Description

@mtrezza

New Feature / Enhancement Checklist

Current Limitation

The GitHub review process is not transparent:

  • For the developers it's unclear from whom to request a review.
  • For the reviewer it is sometimes unclear whether a PR is ready for review if the PR is stale but no review was requested.
  • Reviews are requested personally instead of from a (review) team and therefore burdening individual reviewers.

GitHub does not seem to offer a way to restrict review requests to teams or give teams preference.

Feature / Enhancement Description

A proposal for discussion:

  1. When a PR is created, a bot will automatically apply the draft flag.
  2. When the PR is ready for review, the contributor removes the draft flag.
  3. A bot automatically requests a review from the review team of the repo.
  4. Members of the review team (triage permission) make a review
  5. When N reviews approved, the bot requests a merge from the maintenance team of the repo.
  6. A member of the maintenance team (write permission) merges the PR.

Current restrictions:

  • The write permission gives extensive permissions over the repo, so this should be restricted exclusively to a few people, if possible across repos. The skill to review a PR is not the same as the skill to master git commands and not mess up a repo.

Example Use Case

n/a

Alternatives / Workarounds

n/a

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions