Message error for required fields

[fn-faisal]

Make sure these boxes are checked before submitting your issue -- thanks for reporting issues back to Parse Dashboard!

• You're running version >=1.0.23 of Parse Dashboard.

• You're running version >=2.3.2 of Parse Server.

• You've searched through existing issues. Chances are that your issue has been reported or resolved before.

Steps to reproduce

If I have a field called "test", the message error shows "Test is required" with the letter T in uppercase (see screenshot)

[mtrezza]

I am wondering whether
a) dashboard should re-format the error message, or
b) Parse Server should send more readable error messages

I tend to think (b), because we are lacking a style guide for error messages in Parse Server and now Dashboard tries to correct this, but it seems like addressing the symptom instead of the issue. Error messages appear in a variety of forms:

• beginning upper case or lower case
• with or without trailing dot (.)
• with or without field quotes (e.g. 'test' is required)

And in general, the wording comes in all shapes and forms.

Any error code-dependent logic we implement now into dashboard is just complicating the issue I think. The error message <field> is required is also somewhat ambiguous. Therefore it seems more sustainable to define a style guide for error messages and reword them.

Similar to the wording guideline we have for Security Check.

For example for the message above:

A value for the field test is required to save the object.

[fn-faisal]

In the current implementation, I see in the dashboard
let msg = typeof error === 'string' ? error : error.message; if (msg) { msg = msg[0].toUpperCase() + msg.substr(1); }

The first letter of the all the error messages is currently being capitalised.
So, I think for (b), this would need to be changed in the dashboard too.
The implementation of (b) makes sense.

[mtrezza]

Would you want to tackle (b)? It is surely quite an undertaking, because often tests are also verifying the specific error message. It could also cause breaking changes for developers who parse the error message (which we should really discourage). But I think fixing the error messages would be a sustainable fix and improve the quality of error messages in Parse Server for developers in general.

[fn-faisal]

Implementing (b) would make sense as it'll delegate the responsibility to show an error dialog and the server to send reformatted error strings.

[mtrezza]

So we can close this issue here in the dashboard repo?

[fn-faisal]

I think there's already existing formatting in the dashboard as well which would need to be removed.
I can update this PR or make a new one.

[fn-faisal]

I have made a PR for server parse-community/parse-server#7446 and the dashboard #1737
The formatting is removed from the dashboard and moved to server in these PRs.

[mtrezza]

I'm not sure we should introduce a change in capitalization for a single error message. Not only may this be a breaking change for some deployments, but it is also missing a broader concept of how error messages should be styled across the server. See #1731 (comment).

[fn-faisal]

I've made a new update to the PR for the server parse-community/parse-server#7446 (comment). This PR should remove formatting for frontend. In the master, there's existing formatting for field required error message.