Skip to content
This repository was archived by the owner on Feb 14, 2020. It is now read-only.

Improve styling #39

Merged
merged 2 commits into from
Jul 17, 2018
Merged

Improve styling #39

merged 2 commits into from
Jul 17, 2018

Conversation

Jawnnypoo
Copy link
Member

This PR:

  • Fixes issue with parsing the callback url (caused crash)
  • Improves the visual layout of the login dialog, and allows for overriding of XML layout
  • Autoformats all files to match standard Android Studio formatting

@codecov
Copy link

codecov bot commented Jul 17, 2018

Codecov Report

Merging #39 into master will decrease coverage by 3.67%.
The diff coverage is 26.14%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #39      +/-   ##
============================================
- Coverage     30.88%   27.21%   -3.68%     
  Complexity       19       19              
============================================
  Files             3        5       +2     
  Lines           259      294      +35     
  Branches         23       25       +2     
============================================
  Hits             80       80              
- Misses          169      204      +35     
  Partials         10       10
Impacted Files Coverage Δ Complexity Δ
...brary/src/main/java/com/parse/twitter/Twitter.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...in/java/com/parse/twitter/OAuth1FlowException.java 0% <0%> (ø) 0 <0> (?)
.../main/java/com/parse/twitter/OAuth1FlowDialog.java 0% <0%> (ø) 0 <0> (?)
...main/java/com/parse/twitter/ParseTwitterUtils.java 30% <28.97%> (ø) 11 <11> (ø) ⬇️
...main/java/com/parse/twitter/TwitterController.java 77.04% <75.43%> (ø) 8 <8> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d65e6c0...1ba7e4f. Read the comment docs.

@Jawnnypoo Jawnnypoo merged commit 69022d8 into parse-community:master Jul 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant