Skip to content
This repository was archived by the owner on Jun 13, 2023. It is now read-only.

Full Swift 4.2 compatibility #177

Merged
merged 5 commits into from
Jan 25, 2019
Merged

Conversation

HeEAaD
Copy link
Contributor

@HeEAaD HeEAaD commented Jan 24, 2019

Resolved issues

  • Fix build error of LiveQueryDemo in Xcode 10.2 beta1
SWIFT_VERSION '3.0' is unsupported, supported versions are: 4.0, 4.2, 5.0. (in target 'LiveQueryDemo')
  • Fix build errors of ParseLiveQuery when imported with Cocoapods in Xcode 10.2 beta1
SWIFT_VERSION ‘3.2’ is unsupported, supported versions are: 4.0, 4.2, 5.0. (in target ‘Bolts-Swift’)
SWIFT_VERSION ‘3.2’ is unsupported, supported versions are: 4.0, 4.2, 5.0. (in target ‘ParseLiveQuery’)

Changes

  • convert all targets to Swift 4.2
  • set swift_version in the Podspec to 4.2

Successful test cases

  • Build of schemes "ParseLiveQuery-iOS" and "LiveQueryDemo" in Xcode 10.1 and Xcode 10.2.beta
  • Build of "ParseLiveQuery" in Xcode 10.1 and Xcode 10.2.beta when integrated with Cocapods and Podfile entry
pod 'ParseLiveQuery', :git => 'https://github.com/HeEAaD/ParseLiveQuery-iOS-OSX', :branch => 'swift-4.2'

@flovilmart
Copy link
Contributor

Thanks for the PR. It seems that Travis is miscondugured. Do you believe we could address it before merging?

@HeEAaD HeEAaD force-pushed the swift-4.2 branch 2 times, most recently from 2256130 to 441b3db Compare January 25, 2019 08:35
@HeEAaD
Copy link
Contributor Author

HeEAaD commented Jan 25, 2019

Thanks for the PR. It seems that Travis is miscondugured. Do you believe we could address it before merging?

The coocapods lane is empty for pull requests therefore Travis don't know what to do and it fails.
I added an explicit script step before the cocoapods distribution.

@flovilmart
Copy link
Contributor

Thus is perfect! Thank!

@flovilmart flovilmart merged commit 910fedd into parse-community:master Jan 25, 2019
@maxkattner
Copy link
Contributor

@flovilmart Thanks a lot for your quick review! Do you think you could publish that under a new version to cocoapods so that we can bump our dependencies in our podspecs? That would help us very much :)

@flovilmart
Copy link
Contributor

CAN you make a Pr with the new version number m? Then we’ll be able to publish with a tag. Added you as well as a maintainer

@maxkattner
Copy link
Contributor

@flovilmart Oh yes, sure! I opened #178 just now. Please let me know if something is missing.

@HeEAaD HeEAaD deleted the swift-4.2 branch January 26, 2019 12:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants