Get ws URI directly from server URL #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmimeault
previously requested changes
Mar 26, 2017
| this(null); | ||
| URL serverUrl = ParseRESTCommand.server; | ||
| if (serverUrl == null) { | ||
| throw new RuntimeException("serverUrl is null. " |
There was a problem hiding this comment.
checkInit is already called in the other constructor to do that check.
| } catch (URISyntaxException e) { | ||
| e.printStackTrace(); | ||
| throw new RuntimeException(e.getMessage()); | ||
| } |
There was a problem hiding this comment.
You could extract that logic into a static util
There was a problem hiding this comment.
fixed by 1040abb
| @@ -23,14 +25,37 @@ | |||
| private final String applicationId; | |||
| private final String clientKey; | |||
| private final SparseArray<Subscription<? extends ParseObject>> subscriptions = new SparseArray<>(); | |||
| private final URI uri; | |||
| private URI uri; | |||
There was a problem hiding this comment.
You should keep it final, and only pass the result WSS URL when it's parsed.
rogerhu
reviewed
Mar 27, 2017
| @@ -45,6 +51,25 @@ | |||
| this.webSocketClientCallback = getWebSocketClientCallback(); | |||
| } | |||
|
|
|||
| private static URI getDefaultUri() { | |||
| URL serverUrl = ParseRESTCommand.server; | |||
| if (serverUrl != null) { | |||
There was a problem hiding this comment.
minor change, but i'd return null serverUrl == null and then take this out of an if block
There was a problem hiding this comment.
changed by d50da48
Thanks 😄
rogerhu
approved these changes
Mar 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get ws URI directly from server URL
ex.