Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Spotify authentication #375

Merged
merged 6 commits into from
Jul 9, 2022

Conversation

rocxteady
Copy link
Contributor

@rocxteady rocxteady commented Jun 21, 2022

New Pull Request Checklist

Issue Description

This PR is for adding Spotify to 3rd party login providers.

Related issue: #55

Approach

TODOs before merging

  • Add tests
  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Jun 21, 2022

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #375 (db0b7e0) into main (b0bdf71) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #375      +/-   ##
==========================================
+ Coverage   89.54%   89.66%   +0.11%     
==========================================
  Files         152      155       +3     
  Lines       13969    14123     +154     
==========================================
+ Hits        12509    12663     +154     
  Misses       1460     1460              
Impacted Files Coverage Δ
...on/3rd Party/ParseSpotify/ParseSpotify+async.swift 100.00% <100.00%> (ø)
.../3rd Party/ParseSpotify/ParseSpotify+combine.swift 100.00% <100.00%> (ø)
...tication/3rd Party/ParseSpotify/ParseSpotify.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0bdf71...db0b7e0. Read the comment docs.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@cbaker6 cbaker6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbaker6 cbaker6 merged commit 926fc05 into parse-community:main Jul 9, 2022
@rocxteady rocxteady deleted the spotify-login branch July 9, 2022 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants