Allow custom server URLs to be set and used via ParseClient.Configuration. #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -122,7 +129,7 @@ public struct Configuration { | |||
| /// </param> | |||
| public static void Initialize(Configuration configuration) { | |||
| lock (mutex) { | |||
| HostName = HostName ?? new Uri("https://api.parse.com/1/"); | |||
There was a problem hiding this comment.
do we still HostName? (even in tests). If we don't, we need to clean that up (doesn't need to be in this PR) since it's source of confusion (i.e. which one should I use, HostName or CurrentConfiguration.Server?)
There was a problem hiding this comment.
You're right. I can update all of our internal tests to use Configuration.Server.
richardjrossiii
force-pushed
the
richardross.serverurl.configuration
branch
from
476987f to
79e4376
Compare
|
lgtmcorgi Don't forget to update IntegrationTests EDIT: plz update UnitTests |
richardjrossiii
force-pushed
the
richardross.serverurl.configuration
branch
from
79e4376 to
329ceca
Compare
|
UnitTests now pass. |
|
LGTM |
richardjrossiii
added a commit
that referenced
this pull request
Jan 6, 2016
…iguration Allow custom server URLs to be set and used via ParseClient.Configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.