Skip to content

User subclass for loginWith, hydrate, me #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 26, 2019
Merged

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Oct 25, 2019

No description provided.

@codecov
Copy link

codecov bot commented Oct 25, 2019

Codecov Report

Merging #968 into master will not change coverage.
The diff coverage is 87.5%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #968   +/-   ##
=======================================
  Coverage   91.88%   91.88%           
=======================================
  Files          54       54           
  Lines        5080     5080           
  Branches     1143     1143           
=======================================
  Hits         4668     4668           
  Misses        412      412
Impacted Files Coverage Δ
src/ParseUser.js 82.61% <87.5%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68dd423...e9f6acf. Read the comment docs.

@dplewis dplewis requested a review from acinader October 25, 2019 02:51
Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice.

@dplewis dplewis merged commit 103f05e into master Oct 26, 2019
@dplewis dplewis deleted the improve-user-subclass branch October 26, 2019 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants