Including read preference options in parse query #855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #855 +/- ##
==========================================
- Coverage 92.1% 92.07% -0.03%
==========================================
Files 54 54
Lines 4953 4973 +20
Branches 1103 1109 +6
==========================================
+ Hits 4562 4579 +17
- Misses 391 394 +3
Continue to review full report at Codecov.
|
dplewis
reviewed
Jul 10, 2019
src/ParseQuery.js
Outdated
| * @param {String} subqueryReadPreference The read preference for the sub queries. | ||
| * @return {Parse.Query} Returns the query, so you can chain this call. | ||
| */ | ||
| readPreference(readPreference: string, includeReadPreference: string, subqueryReadPreference: string): ParseQuery { |
Member
There was a problem hiding this comment.
Are all theses fields required? For typing you can do:
includeReadPreference?: string, subqueryReadPreference?: string
…n using query.readPreference() method
dplewis
approved these changes
Jul 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See parse-community/parse-server#5515