Skip to content

Conversation

@dplewis
Copy link
Member

@dplewis dplewis commented May 10, 2019

No description provided.

@codecov
Copy link

codecov bot commented May 10, 2019

Codecov Report

Merging #821 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #821   +/-   ##
=======================================
  Coverage   92.07%   92.07%           
=======================================
  Files          54       54           
  Lines        4933     4933           
  Branches     1097     1097           
=======================================
  Hits         4542     4542           
  Misses        391      391

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2edc162...b86bdc6. Read the comment docs.

@dplewis dplewis requested a review from acinader May 13, 2019 17:37
README.md Outdated

## Want to ride the bleeding edge?

It is recommend to use builds deployed npm for many reasons, but if you want to use
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this first sentence needs some work.

"We recommend using the most recent tagged build published to npm for production. However, you can test not-yet-released versions of the Parse-SDK-JS by referencing specific branches in your package.json. For example, to use the master branch: ...."

@acinader acinader requested a review from TomWFox May 13, 2019 17:47
@ghost
Copy link

ghost commented May 13, 2019

Fails
🚫

Could not find Dangerfile at dangerfiles/greenkeeper.ts on parse-community/parse-community-peril on branch master

Full state of PR run:

{
"branch": null,
"dangerfileBranchForPR": "branch-build",
"neededDangerfileIsLocalRepo": false,
"repoForDangerfileRun": "parse-community/parse-community-peril",
"run": {
  "action": "review_requested",
  "dslType": 0,
  "event": "pull_request",
  "branch": "master",
  "dangerfilePath": "dangerfiles/greenkeeper.ts",
  "repoSlug": "parse-community/parse-community-peril",
  "referenceString": "parse-community/parse-community-peril@dangerfiles/greenkeeper.ts",
  "feedback": 0
},
"settings": {
  "commentableID": 821,
  "eventID": "Unknown",
  "hasRelatedCommentable": true,
  "installationID": 36561,
  "installationSettings": {
    "env_vars": [],
    "ignored_repos": [],
    "modules": []
  },
  "isRepoEvent": true,
  "isTriggeredByUser": true,
  "repoName": "parse-community/Parse-SDK-JS",
  "repoSpecificRules": {},
  "triggeredByUsername": "acinader"
}
}

Generated by 🚫 dangerJS

Copy link
Contributor

@TomWFox TomWFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs look good apart from what @acinader already brought up 👍

@dplewis dplewis merged commit 577ffb4 into master May 13, 2019
@dplewis dplewis deleted the branch-build branch May 13, 2019 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants