-
-
Notifications
You must be signed in to change notification settings - Fork 597
eslint on src and src/__tests__ #638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #638 +/- ##
==========================================
+ Coverage 85.51% 85.55% +0.03%
==========================================
Files 48 48
Lines 3894 3877 -17
Branches 881 877 -4
==========================================
- Hits 3330 3317 -13
+ Misses 564 560 -4
Continue to review full report at Codecov.
|
src/Cloud.js
Outdated
@@ -59,23 +59,22 @@ export function run( | |||
return CoreManager.getCloudController().run(name, data, requestOptions); | |||
} | |||
|
|||
/** | |||
/** | |||
* Gets data for the current set of cloud jobs. | |||
* @method getJobsData | |||
* @name Parse.Cloud.getJobsData | |||
* @param {Object} options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few places where you removed options parameter but they still exist in the docs.
https://github.com/gajus/eslint-plugin-jsdoc
or
https://eslint.org/docs/rules/valid-jsdoc
Maybe we can use something like these plugin to validate the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, gotta have a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
valid-jsdoc yields an additional 200 errors ;) let's add it later ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree everything looks good to me here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome!
No description provided.