Skip to content

eslint on src and src/__tests__ #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 13, 2018
Merged

eslint on src and src/__tests__ #638

merged 5 commits into from
Aug 13, 2018

Conversation

flovilmart
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 13, 2018

Codecov Report

Merging #638 into master will increase coverage by 0.03%.
The diff coverage is 77.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #638      +/-   ##
==========================================
+ Coverage   85.51%   85.55%   +0.03%     
==========================================
  Files          48       48              
  Lines        3894     3877      -17     
  Branches      881      877       -4     
==========================================
- Hits         3330     3317      -13     
+ Misses        564      560       -4
Impacted Files Coverage Δ
src/ParseACL.js 94.06% <ø> (ø) ⬆️
src/StorageController.browser.js 100% <ø> (ø) ⬆️
src/decode.js 96.66% <ø> (ø) ⬆️
src/LiveQuerySubscription.js 50% <ø> (ø) ⬆️
src/InstallationController.js 95% <ø> (ø) ⬆️
src/ParseSession.js 89.47% <ø> (-0.27%) ⬇️
src/Push.js 100% <ø> (ø) ⬆️
src/Parse.js 80.59% <ø> (-0.29%) ⬇️
src/ParseError.js 100% <ø> (ø) ⬆️
src/FacebookUtils.js 4.22% <0%> (-1.34%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca9000e...902a3d3. Read the comment docs.

@flovilmart flovilmart requested a review from dplewis August 13, 2018 19:59
src/Cloud.js Outdated
@@ -59,23 +59,22 @@ export function run(
return CoreManager.getCloudController().run(name, data, requestOptions);
}

/**
/**
* Gets data for the current set of cloud jobs.
* @method getJobsData
* @name Parse.Cloud.getJobsData
* @param {Object} options
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few places where you removed options parameter but they still exist in the docs.

https://github.com/gajus/eslint-plugin-jsdoc

or

https://eslint.org/docs/rules/valid-jsdoc

Maybe we can use something like these plugin to validate the docs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, gotta have a look.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

valid-jsdoc yields an additional 200 errors ;) let's add it later ;)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree everything looks good to me here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@flovilmart flovilmart merged commit db59b63 into master Aug 13, 2018
@flovilmart flovilmart deleted the linter branch August 13, 2018 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants