Skip to content

Fix Parse File upload problem via ajax #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2018

Conversation

miconblog
Copy link
Contributor

Before this PR:

var parseFile = new Parse.File('filename', file);
parseFile.save().then((f)=>{
    console.log(f.toJSON())  // {__type: "File", name: undefined, url: undefined}
});

i think it is a bug and related this issue: #558
RESTController.ajax method was return with response object, you can see that Implementation in here and here

@flovilmart
Copy link
Contributor

The bug you are describing should only be present on the master branch, and only since a few days ago. Ca you confirm ?

@miconblog
Copy link
Contributor Author

yes, sure!

@flovilmart
Copy link
Contributor

How is it related to the bug you are describing? how did you encounter this issue in the first place?

@codecov
Copy link

codecov bot commented Aug 9, 2018

Codecov Report

Merging #628 into master will increase coverage by 0.38%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #628      +/-   ##
==========================================
+ Coverage   84.59%   84.98%   +0.38%     
==========================================
  Files          48       48              
  Lines        3850     3850              
  Branches      871      871              
==========================================
+ Hits         3257     3272      +15     
+ Misses        593      578      -15
Impacted Files Coverage Δ
src/ParseFile.js 94.28% <100%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 688e936...a180224. Read the comment docs.

@miconblog
Copy link
Contributor Author

yesterday I upgrade the SDK from 1.11.1 to 2.0 and i found this problem in my web project.

@flovilmart
Copy link
Contributor

Excellent :) Thanks!

@flovilmart flovilmart merged commit 64aacec into parse-community:master Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants