Skip to content

Adds ability to watch the build #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2018
Merged

Adds ability to watch the build #614

merged 1 commit into from
Jul 29, 2018

Conversation

flovilmart
Copy link
Contributor

@flovilmart flovilmart commented Jul 28, 2018

@dplewis hope this will help you, check this branch out and let me know if it does what your're expecting.

@flovilmart flovilmart requested a review from dplewis July 28, 2018 22:34
@codecov
Copy link

codecov bot commented Jul 28, 2018

Codecov Report

Merging #614 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #614   +/-   ##
=======================================
  Coverage   84.57%   84.57%           
=======================================
  Files          48       48           
  Lines        4039     4039           
  Branches      911      911           
=======================================
  Hits         3416     3416           
  Misses        623      623

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 358a335...4c8f624. Read the comment docs.

@dplewis dplewis removed their request for review July 29, 2018 16:56
Copy link
Member

@dplewis dplewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@flovilmart flovilmart merged commit 5b3379f into master Jul 29, 2018
@flovilmart flovilmart deleted the watch-nodejs branch July 29, 2018 16:59
@dplewis
Copy link
Member

dplewis commented Jul 29, 2018

@flovilmart Thanks a lot! Might want to update that CONTIBUTION.MD...

@dplewis
Copy link
Member

dplewis commented Jul 29, 2018

Also Pin the package, don't want any more drama lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants