Moves integration test at top level with jasmine #593

flovilmart · 2018-07-04T20:22:32Z

Use jasmine so toolchain is similar to parse-server
Replaces bash script with pre-test

- Use jasmine so toolchain is similar to parse-server - Replaces bash script with pre-test

codecov · 2018-07-04T20:26:23Z

Codecov Report

Merging #593 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #593   +/-   ##
=======================================
  Coverage   84.57%   84.57%           
=======================================
  Files          48       48           
  Lines        4039     4039           
  Branches      911      911           
=======================================
  Hits         3416     3416           
  Misses        623      623

Impacted Files	Coverage Δ
src/LiveQueryClient.js	`86.66% <ø> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25d13ed...17b2616. Read the comment docs.

dplewis

Just a few more nits. I was able to install VSCode and the Extensions. I'll have to get used to using it tho.

dplewis · 2018-07-10T21:06:04Z

CONTRIBUTING.md

@@ -1,35 +1,60 @@
 # Contributing to the Parse JavaScript SDK
 We want to make contributing to this project as easy and transparent as possible.

-If you're looking to get started, but want to ease yourself into the codebase, look for issues tagged [good first bug](https://github.com/ParsePlatform/Parse-SDK-JS/labels/good%20first%20bug). These are simple yet valuable tasks that should be easy to get started.
+If you're looking to get started, but want to ease yourself into the codebase, look for issues tagged [good first bug](https://github.com/parse-community/Parse-SDK-JS/labels/good%20first%20bug). These are simple yet valuable tasks that should be easy to get started.


There isn't a good first bug label there is a good first task

https://github.com/parse-community/Parse-SDK-JS/labels/good%20first%20task

dplewis · 2018-07-10T21:10:29Z

CONTRIBUTING.md

+### Recommended setup:
+
+* [vscode](https://code.visualstudio.com), the popular IDE.
+* [Jest Extesnsion](https://marketplace.visualstudio.com/items?itemName=Orta.vscode-jest) the Jest extension for vscode to run the tests inline and debug quicky.


dplewis · 2018-07-10T21:55:52Z

CONTRIBUTING.md

@@ -40,27 +65,32 @@ Not all issues are SDK issues. If you're unsure whether your bug is with the SDK
 Details are key. The more information you provide us the easier it'll be for us to debug and the faster you'll receive a fix. Some examples of useful tidbits:

 * A description. What did you expect to happen and what actually happened? Why do you think that was wrong?
-* A simple unit test that fails. Refer [here][tests-dir] for examples of existing unit tests. See our [README](README.md#usage) for how to run unit tests. You can submit a pull request with your failing unit test so that our CI verifies that the test fails.
+* A simple unit test that fails. Refer [here][tests-dir] for examples of existing unit tests and [here](integration-test-dir) for integration tests examples. See for how to setup your machine and run unit tests in [this]() guide. You can submit a pull request with your failing unit test so that our CI verifies that the test fails.


Most of the links here are broken...

flovilmart · 2018-07-11T07:15:38Z

Thanks for the review @dplewis, i’ll Fix up before end of week

flovilmart · 2018-07-17T08:28:14Z

@dplewis I fixed the links, and checked them, let me know!

dplewis

nit

dplewis · 2018-07-19T05:57:15Z

CONTRIBUTING.md

- [rest-api]: https://www.parse.com/docs/rest/guide
+ [stack-overflow]: http://stackoverflow.com/tags/parse-server
+ [bug-reports]: https://github.com/parse-community/parse-server/issues
+ [rest-api]: https://docs.parseplatform.org/rest/guide
 [parse-api-console]: http://blog.parse.com/announcements/introducing-the-parse-api-console/


The link should be http://blog.parseplatform.org/announcements/introducing-the-parse-api-console/

dplewis · 2018-07-26T00:55:34Z

@flovilmart Whats the status here?

flovilmart · 2018-07-26T19:50:30Z

@dplewis that looks all good!

dplewis · 2018-07-28T17:05:23Z

@flovilmart In parse-server you added npm run watch would it be possible to add it here.

When I'm testing I only need to rebuild node, not browser / react. Its kinda time consuming.

flovilmart · 2018-07-28T17:12:19Z

Ah right, I believe that should be ~~easy~~ feasible, as it’s gulp based, with gulp-watch you should be able to craft something ~~easily~~ https://www.npmjs.com/package/gulp-watch

edit: nothing is easy

dplewis · 2018-07-28T17:16:46Z

Can you add it? 🙏

My knowledge of gulp is a little above zero.

Currently I'm having this error

[12:15:37] Starting 'browserify'...
[12:15:38] The following tasks did not complete: browserify
[12:15:38] Did you forget to signal async completion?

flovilmart · 2018-07-28T17:17:39Z

Uhm yeah I'll need to have a look, but it's gonna be later today, busy on something else now ;) Would be faster for you to learn gulp :P

Moves integration test at top level with jasmine

924f8ab

- Use jasmine so toolchain is similar to parse-server - Replaces bash script with pre-test

flovilmart force-pushed the use-jasmine-no-mocha branch from 9bc3b14 to 924f8ab Compare July 4, 2018 20:26

flovilmart added 2 commits July 6, 2018 12:06

Update contributing guide

560d61e

Updates URLs

db94f9d

flovilmart requested a review from dplewis July 6, 2018 10:06

nits

4cca58c

dplewis suggested changes Jul 10, 2018

View reviewed changes

nits

6b118ff

flovilmart force-pushed the use-jasmine-no-mocha branch from 20739c2 to 6b118ff Compare July 17, 2018 08:27

dplewis suggested changes Jul 19, 2018

View reviewed changes

flovilmart and others added 2 commits July 26, 2018 07:00

nit

0adbd2d

Merge branch 'master' into use-jasmine-no-mocha

17b2616

dplewis approved these changes Jul 26, 2018

View reviewed changes

dplewis merged commit 358a335 into master Jul 26, 2018

dplewis deleted the use-jasmine-no-mocha branch July 26, 2018 19:51

Uh oh!

Moves integration test at top level with jasmine #593

Moves integration test at top level with jasmine #593

Uh oh!

Conversation

flovilmart commented Jul 4, 2018

Uh oh!

codecov bot commented Jul 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dplewis left a comment

Choose a reason for hiding this comment

Uh oh!

dplewis Jul 10, 2018

Choose a reason for hiding this comment

Uh oh!

dplewis Jul 10, 2018

Choose a reason for hiding this comment

Uh oh!

dplewis Jul 10, 2018

Choose a reason for hiding this comment

Uh oh!

flovilmart commented Jul 11, 2018

Uh oh!

flovilmart commented Jul 17, 2018

Uh oh!

dplewis left a comment

Choose a reason for hiding this comment

Uh oh!

dplewis Jul 19, 2018

Choose a reason for hiding this comment

Uh oh!

dplewis commented Jul 26, 2018

Uh oh!

flovilmart commented Jul 26, 2018

Uh oh!

dplewis commented Jul 28, 2018

Uh oh!

flovilmart commented Jul 28, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dplewis commented Jul 28, 2018

Uh oh!

flovilmart commented Jul 28, 2018

Uh oh!

Uh oh!

codecov bot commented Jul 4, 2018 •

edited

Loading

flovilmart commented Jul 28, 2018 •

edited

Loading