fix: `Parse.Object.get` returns array instead of object if key name is number-like #2201

mtrezza · 2024-07-02T00:41:29Z

Pull Request

Report security issues confidentially.
Any contribution is under this license.
Link this pull request to an issue.

Issue

Closes: #2198

Approach

Issue demo

Tasks

Add tests

parse-github-assistant · 2024-07-02T00:41:32Z

Thanks for opening this pull request!

src/ObjectStateMutations.ts

Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>

integration/test/ParseObjectTest.js

Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>

integration/test/ParseObjectTest.js

Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>

mkmandar123 · 2024-07-05T12:20:46Z

@mtrezza this fix would return wrong output e.g.

{ field: 'object', value: { '1x1': 1, '2': 2, '3': 3 } }, return as jsonArray which is wrong
{ field: 'object', value: { '1': 1 } }, return as jsonArray which is also wrong as 0 index is missing
I have created a PR fix: Objects wrongly getting converted to Array #2206 which considers these cases as well.

mtrezza · 2024-07-05T20:10:42Z

An index of 0 is not required for an array to be an array. See #2198 (comment).

src/ObjectStateMutations.ts

src/__tests__/ObjectStateMutations-test.js

codecov · 2024-07-07T11:40:51Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b50790a) to head (83066f2).
Report is 103 commits behind head on alpha.

Additional details and impacted files

@@            Coverage Diff             @@
##             alpha     #2201    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           61        64     +3     
  Lines         6186      6358   +172     
  Branches      1499      1528    +29     
==========================================
+ Hits          6186      6358   +172

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mtrezza · 2024-07-07T12:32:31Z

@dplewis anything else that should be removed from the changes in https://github.com/parse-community/Parse-SDK-JS/pull/2120/files? Or can we merge

dplewis · 2024-07-07T12:34:30Z

Thats it, this is ready to merge

# [5.3.0-alpha.2](5.3.0-alpha.1...5.3.0-alpha.2) (2024-07-07) ### Bug Fixes * `Parse.Object.get` returns array instead of object if key name is number-like ([#2201](#2201)) ([5921ba2](5921ba2))

parseplatformorg · 2024-07-07T12:46:56Z

🎉 This change has been released in version 5.3.0-alpha.2

# [5.3.0-beta.1](5.2.0...5.3.0-beta.1) (2024-07-07) ### Bug Fixes * `Parse.Object.get` returns array instead of object if key name is number-like ([#2201](#2201)) ([5921ba2](5921ba2)) ### Features * Add support for Node 22 ([#2209](#2209)) ([c74fd4c](c74fd4c))

parseplatformorg · 2024-07-07T15:31:48Z

🎉 This change has been released in version 5.3.0-beta.1

# [5.3.0](5.2.0...5.3.0) (2024-07-07) ### Bug Fixes * `Parse.Object.get` returns array instead of object if key name is number-like ([#2201](#2201)) ([5921ba2](5921ba2)) ### Features * Add support for Node 22 ([#2209](#2209)) ([c74fd4c](c74fd4c))

parseplatformorg · 2024-07-07T15:43:41Z

🎉 This change has been released in version 5.3.0

mtrezza added 2 commits July 2, 2024 02:35

Update ParseObjectTest.js

c82eb4e

Update ParseObjectTest.js

9cd41e7

mtrezza added 2 commits July 2, 2024 03:28

udpate

6b7d271

Update ParseObjectTest.js

d89efcb

This was referenced Jul 2, 2024

Object attributes transformed in array #2198

Closed

fix: Incorrect Parse.Object field values with Parse JS SDK 5.2.0 parse-community/parse-server#9174

Closed

mtrezza commented Jul 5, 2024

View reviewed changes

src/ObjectStateMutations.ts Outdated Show resolved Hide resolved

Update ObjectStateMutations.ts

48699d9

Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>

mtrezza commented Jul 5, 2024

View reviewed changes

integration/test/ParseObjectTest.js Show resolved Hide resolved

Update ParseObjectTest.js

1f3f28a

Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>

mtrezza commented Jul 5, 2024

View reviewed changes

integration/test/ParseObjectTest.js Show resolved Hide resolved

Update ParseObjectTest.js

ca30051

Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>

mtrezza mentioned this pull request Jul 5, 2024

fix: Objects wrongly getting converted to Array #2206

Closed

dplewis suggested changes Jul 5, 2024

View reviewed changes

src/ObjectStateMutations.ts Outdated Show resolved Hide resolved

mtrezza added 4 commits July 6, 2024 15:10

Update ParseObjectTest.js

764c078

Update ObjectStateMutations.ts

b0254c3

revert JSON array check

ea09c84

unfit

81a2d08

dplewis suggested changes Jul 7, 2024

View reviewed changes

src/__tests__/ObjectStateMutations-test.js Show resolved Hide resolved

mtrezza added 2 commits July 7, 2024 14:30

add test

0457db8

Merge branch 'alpha' into fix/json-array

2aed151

mtrezza added 2 commits July 7, 2024 14:35

Merge branch 'alpha' into fix/json-array

b1d9eba

Merge branch 'alpha' into fix/json-array

83066f2

mtrezza changed the title ~~fix: Parse Object field value converts from object to array if key contains number~~ fix: Parse.Object.get returns array instead of object value if key name is number-like Jul 7, 2024

mtrezza changed the title ~~fix: Parse.Object.get returns array instead of object value if key name is number-like~~ fix: Parse.Object.get returns array instead of object if key name is number-like Jul 7, 2024

mtrezza merged commit 5921ba2 into parse-community:alpha Jul 7, 2024

mtrezza deleted the fix/json-array branch July 7, 2024 12:46

parseplatformorg added the state:released-alpha Released as alpha version label Jul 7, 2024

mtrezza mentioned this pull request Jul 7, 2024

test: Add test to return correct field values parse-community/parse-server#9179

Merged

parseplatformorg added the state:released-beta Released as beta version label Jul 7, 2024

parseplatformorg added the state:released Released as stable version label Jul 7, 2024

parseplatformorg mentioned this pull request Jul 29, 2024

refactor: Upgrade parse from 5.2.0 to 5.3.0 parse-community/parse-server-push-adapter#272

Closed

parseplatformorg mentioned this pull request Oct 26, 2024

refactor: Upgrade parse from 4.2.0 to 5.3.0 parse-community/parse-server#9379

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: `Parse.Object.get` returns array instead of object if key name is number-like #2201

fix: `Parse.Object.get` returns array instead of object if key name is number-like #2201

Uh oh!

mtrezza commented Jul 2, 2024 •

edited

Loading

Uh oh!

parse-github-assistant bot commented Jul 2, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mkmandar123 commented Jul 5, 2024

Uh oh!

mtrezza commented Jul 5, 2024

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jul 7, 2024 •

edited

Loading

Uh oh!

mtrezza commented Jul 7, 2024

Uh oh!

dplewis commented Jul 7, 2024

Uh oh!

parseplatformorg commented Jul 7, 2024

Uh oh!

parseplatformorg commented Jul 7, 2024

Uh oh!

parseplatformorg commented Jul 7, 2024

Uh oh!

Uh oh!

Uh oh!

fix: Parse.Object.get returns array instead of object if key name is number-like #2201

fix: Parse.Object.get returns array instead of object if key name is number-like #2201

Uh oh!

Conversation

mtrezza commented Jul 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request

Issue

Approach

Tasks

Uh oh!

parse-github-assistant bot commented Jul 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Thanks for opening this pull request!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mkmandar123 commented Jul 5, 2024

Uh oh!

mtrezza commented Jul 5, 2024

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jul 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mtrezza commented Jul 7, 2024

Uh oh!

dplewis commented Jul 7, 2024

Uh oh!

parseplatformorg commented Jul 7, 2024

Uh oh!

parseplatformorg commented Jul 7, 2024

Uh oh!

parseplatformorg commented Jul 7, 2024

Uh oh!

Uh oh!

fix: `Parse.Object.get` returns array instead of object if key name is number-like #2201

fix: `Parse.Object.get` returns array instead of object if key name is number-like #2201

mtrezza commented Jul 2, 2024 •

edited

Loading

parse-github-assistant bot commented Jul 2, 2024 •

edited

Loading

codecov bot commented Jul 7, 2024 •

edited

Loading