Skip to content

ci: Properly handle open connections after the tests finish #2185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Jun 23, 2024

Pull Request

Issue

I realized the the open connections to the server in the test suite are just the node process to run Jasmine. This causes a lot of clutter in the CI logs when trying to review PRs. Logging to console also slows down the test suite.

Screenshot 2024-06-23 at 3 25 10 PM

Approach

  • Keep all connections alive until end of the test suite
  • Remove destroying of open connections
  • Remove sleep(0) from execution
  • Perf: save ~10 seconds in the test suite

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)

Copy link

parse-github-assistant bot commented Jun 23, 2024

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

Copy link

codecov bot commented Jun 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d76328c) to head (80effb0).

Additional details and impacted files
@@            Coverage Diff            @@
##             alpha     #2185   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           64        64           
  Lines         6364      6364           
  Branches      1535      1507   -28     
=========================================
  Hits          6364      6364           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dplewis dplewis requested a review from a team June 23, 2024 20:39
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; waiting for CI to pass...

@mtrezza mtrezza merged commit 11169a4 into parse-community:alpha Jun 24, 2024
11 checks passed
@dplewis dplewis deleted the open-connections branch June 24, 2024 20:28
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.2.0-alpha.3

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jun 24, 2024
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.2.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jun 24, 2024
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants