-
-
Notifications
You must be signed in to change notification settings - Fork 597
ci: Properly handle open connections after the tests finish #2185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening this pull request!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #2185 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 64 64
Lines 6364 6364
Branches 1535 1507 -28
=========================================
Hits 6364 6364 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; waiting for CI to pass...
🎉 This change has been released in version 5.2.0-alpha.3 |
🎉 This change has been released in version 5.2.0-beta.1 |
🎉 This change has been released in version 5.2.0 |
Pull Request
Issue
I realized the the open connections to the server in the test suite are just the node process to run Jasmine. This causes a lot of clutter in the CI logs when trying to review PRs. Logging to console also slows down the test suite.
Approach
sleep(0)
from executionTasks