Skip to content

Conversation

@dplewis
Copy link
Member

@dplewis dplewis commented Jun 23, 2024

Pull Request

Issue

Attempt to fix flaky tests when the server isn't properly initialized. I believe this is caused by tests that shuts down the server to reproduce a disconnection and restarts. I am unable to reproduce this issue local so the CI should be ran a few times to ensure it works.

Closes: parse-community/parse-server#9149

Approach

  • Properly handle server shutdown
  • Refactor helper.js
  • Add retry strategy if server isn't properly initialized

@parse-github-assistant
Copy link

parse-github-assistant bot commented Jun 23, 2024

Thanks for opening this pull request!

@dplewis dplewis requested a review from a team June 23, 2024 17:19
@codecov
Copy link

codecov bot commented Jun 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b50790a) to head (2b03abd).
Report is 83 commits behind head on alpha.

Additional details and impacted files
@@            Coverage Diff             @@
##             alpha     #2183    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           61        64     +3     
  Lines         6186      6365   +179     
  Branches      1499      1534    +35     
==========================================
+ Hits          6186      6365   +179     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtrezza mtrezza merged commit 450142c into parse-community:alpha Jun 25, 2024
@dplewis dplewis deleted the invalid-server-state branch June 28, 2024 01:26
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.2.0-alpha.4

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jun 28, 2024
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.2.0-beta.2

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jun 29, 2024
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.2.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky Tests Invalid server state: initialized

3 participants