ci: Fix flaky tests due to open server connection

[dplewis]

New Pull Request Checklist

• I am not disclosing a vulnerability.
• I am creating this PR in reference to an issue.

Issue Description

Sometimes the job status is returned as running when it should be failed. The status is returned too quickly before the job failed.

Parse Cloud run failing job
  Message:
    Unhandled promise rejection: AssertionError [ERR_ASSERTION]: 'running' == 'failed'

I've taken initial steps to find the fix for this. Once a test finishes there shouldn't be any open connections to the server. If there are then we log them in the CI and fix the as we go. Hopefully we can find which test is leaking.

- Error: Timeout - Async function did not complete within 20000ms (set by jasmine.DEFAULT_TIMEOUT_INTERVAL)
        - MongoNotConnectedError: Client must be connected before running operations

I removed the beforeAll from ParseDistTest as I only recommend using only one beforeAll in the test suite (one already exists in helper.js). I ensured the headless browser closes and doesn't leave any connections to the server.

Approach

Refactor Cloud Code Jobs to wait for the job status to change.

TODOs before merging

• Add tests
• Add changes to documentation (guides, repository pages, in-code descriptions)

[parse-github-assistant]

Thanks for opening this pull request!

• ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

[codecov]

Codecov Report

Base: 99.89% // Head: 99.89% // No change to project coverage 👍

Coverage data is based on head (93e2a7c) compared to base (8f8e978).
Patch has no changes to coverable lines.

Additional details and impacted files

@@           Coverage Diff           @@
##            alpha    #1670   +/-   ##
=======================================
  Coverage   99.89%   99.89%           
=======================================
  Files          61       61           
  Lines        5977     5977           
  Branches     1369     1369           
=======================================
  Hits         5971     5971           
  Misses          6        6           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[mtrezza]

Glad this is fixed, can we merge?

[dplewis]

@mtrezza This can be merged

[dplewis]

@mtrezza The issue is reconfigureServer for sure or related to it as I mentioned here

[dplewis]

@mtrezza I also noticed that the Node 14 build takes 17 minutes because of the mongodb-runner being installed globally. Should we move it to the devDependencies to increase the speed.

[mtrezza]

I guess we can move it; do you know what this is only affecting Node 14?

[dplewis]

I have no idea, the server tests work just fine for Node 14.

[mtrezza]

It could be this:

Parse-SDK-JS/.github/workflows/ci.yml

Lines 37 to 39 in bea817e

	- name: Fix git protocol for Node 14
	if: ${{ startsWith(matrix.NODE_VERSION, '14.') }}
	run: sudo git config --system url."https://github".insteadOf "ssh://git@github"

But this has been added because otherwise some dependencies won't download at all.

[mtrezza]

Is this ready for merge?

[dplewis]

@mtrezza this is ready to merge once the 17 minute CI passes. I'll play around with the CI for node 14 to see if I can find a better fix

[mtrezza]

The 17min CI passed, I'll go ahead and merge

[parseplatformorg]

🎉 This change has been released in version 4.0.0-alpha.7

[parseplatformorg]

🎉 This change has been released in version 4.0.1-beta.1

[parseplatformorg]

🎉 This change has been released in version 4.0.1