Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve support for nested keys #1364

Merged
merged 5 commits into from
May 14, 2021
Merged

Improve support for nested keys #1364

merged 5 commits into from
May 14, 2021

Conversation

mstniy
Copy link
Contributor

@mstniy mstniy commented May 13, 2021

Solves #1363

@mstniy
Better support for nested keys
293011e
@mstniy
Added a test for nested fields
7b8a66a 
Bugfix on ObjectStateMutations patch
@mstniy
Move the new test under integration/
a628b69
@mstniy
Modified an existing test
1ed03b3 
  ParseUser.get('password') used to return undefined, now password is not an attribute
@codecov
Copy link

codecov bot commented May 13, 2021 •
edited
Loading

Codecov Report

Merging #1364 (6f9b11e) into master (86c05ad) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1364   +/-   ##
=======================================
  Coverage   99.10%   99.10%           
=======================================
  Files          61       61           
  Lines        5933     5941    +8     
  Branches     1347     1349    +2     
=======================================
+ Hits         5880     5888    +8     
  Misses         52       52           
  Partials        1        1
Impacted Files Coverage Δ
src/ObjectStateMutations.js 100.00% <100.00%> (ø)
src/ParseObject.js 99.89% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86c05ad...6f9b11e. Read the comment docs.

@mstniy mstniy mentioned this pull request May 13, 2021
Draft
8 tasks
dplewis
dplewis suggested changes May 13, 2021
View reviewed changes
Copy link
Member

@dplewis dplewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a quick nit from me

src/ObjectStateMutations.js Outdated Show resolved Hide resolved
@dplewis dplewis merged commit ffc523f into parse-community:master May 14, 2021
@dplewis dplewis mentioned this pull request May 14, 2021
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dplewis dplewis dplewis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mstniy @dplewis