Skip to content

[bug] Fix weapp uuid error. #1356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2021
Merged

Conversation

onerain88
Copy link
Contributor

In weapp, crypto is not provided.
So, I fake it with random string for installation id.

@davimacedo
Copy link
Member

It makes sense to me. What do you think @dplewis ?

@dplewis
Copy link
Member

dplewis commented May 7, 2021

The uuid module is used in other places besides the InstallationController. I think a separate uuid.js file would suffice.

@onerain88
Copy link
Contributor Author

I wrapped the uuid.js instead of uuid/v4

@codecov
Copy link

codecov bot commented May 8, 2021

Codecov Report

Merging #1356 (e69107c) into master (66878f2) will decrease coverage by 0.13%.
The diff coverage is 52.94%.

❗ Current head e69107c differs from pull request most recent head 49d0eb4. Consider uploading reports for the commit 49d0eb4 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1356      +/-   ##
==========================================
- Coverage   99.23%   99.10%   -0.14%     
==========================================
  Files          60       61       +1     
  Lines        5920     5933      +13     
  Branches     1346     1347       +1     
==========================================
+ Hits         5875     5880       +5     
- Misses         44       52       +8     
  Partials        1        1              
Impacted Files Coverage Δ
src/uuid.js 38.46% <38.46%> (ø)
src/AnonymousUtils.js 100.00% <100.00%> (ø)
src/InstallationController.js 100.00% <100.00%> (ø)
src/ParseObject.js 99.89% <100.00%> (ø)
src/RESTController.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66878f2...49d0eb4. Read the comment docs.

Copy link
Member

@dplewis dplewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dplewis dplewis merged commit e6f15fd into parse-community:master May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants