Skip to content

Remove deletion of Anonymous User on logout #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 19, 2021
Merged

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Mar 19, 2021

Based on conversation here

  • Remove deletion on logout
  • Remove deletion on setCurrentUser
  • Exposes registered on AnonymousUtils

@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #1324 (4809af0) into master (7d28956) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head 4809af0 differs from pull request most recent head d36a22d. Consider uploading reports for the commit d36a22d to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##            master    #1324      +/-   ##
===========================================
- Coverage   100.00%   99.94%   -0.06%     
===========================================
  Files           60       60              
  Lines         5853     5847       -6     
  Branches      1313     1311       -2     
===========================================
- Hits          5853     5844       -9     
- Misses           0        3       +3     
Impacted Files Coverage Δ
src/AnonymousUtils.js 100.00% <100.00%> (ø)
src/ParseUser.js 99.57% <100.00%> (-0.43%) ⬇️
src/ParseObject.js 99.89% <0.00%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d28956...d36a22d. Read the comment docs.

@dplewis dplewis requested review from davimacedo and mtrezza March 19, 2021 01:28
Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me and makes more sense now. Should we classify it as a breaking change?

@dplewis dplewis merged commit 039ec84 into master Mar 19, 2021
@dplewis dplewis deleted the logout-on-invalid branch March 19, 2021 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants