Skip to content

Add modifiers to startsWith / endsWith #1306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2021
Merged

Add modifiers to startsWith / endsWith #1306

merged 1 commit into from
Feb 23, 2021

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Feb 23, 2021

Closes: #1304

@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #1306 (49e72c3) into master (1abb841) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1306   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           60        60           
  Lines         5837      5837           
  Branches      1312      1312           
=========================================
  Hits          5837      5837           
Impacted Files Coverage Δ
src/ParseQuery.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1abb841...5ee8baf. Read the comment docs.

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dplewis dplewis merged commit f31929b into master Feb 23, 2021
@dplewis dplewis deleted the regex-modifiers branch February 23, 2021 19:46
@mtrezza
Copy link
Member

mtrezza commented Feb 23, 2021

I'm a bit surprised we maintain startsWith and endsWith. I would deprecate these methods to keep the codebase small, because they just seem to add a single regex char ^ or $ to matches. I think one char does not really merit maintaining all the additional code and tests.

@dplewis
Copy link
Member Author

dplewis commented Feb 23, 2021

Yeah but nobody likes regex expressions and new users can just use the functions. They are also used in the dashboard as well.

@mtrezza
Copy link
Member

mtrezza commented Feb 23, 2021

Yeah but nobody likes regex expressions

@TomWFox when are we launching a Parse Platform merch shop and begin printing these things on t-shirts?

@TomWFox
Copy link
Contributor

TomWFox commented Feb 23, 2021

http://teemill.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ParseObject.startsWith & endsWith cannot be use in a case-insensitive way
3 participants