Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems we do not handle ACL on save. Normally for a save/update, the server just return
createAt, objectId
andupdateAt
, so it is fine. However, if the developers enable beforeSave for this class, the server will return the full object. In this situation, if we do not handle ACL, it will makeobject.getACL()
returnnull
.I follow the way we handle ACL in
_finishFetch
to handle ACL. Not sure it is the best way to do that.