Add support to add hint to Parse.Query #1054
Conversation
updated master
Codecov Report
@@ Coverage Diff @@
## master #1054 +/- ##
=========================================
- Coverage 92.21% 92.2% -0.02%
=========================================
Files 54 54
Lines 5162 5167 +5
Branches 1148 1157 +9
=========================================
+ Hits 4760 4764 +4
- Misses 402 403 +1
Continue to review full report at Codecov.
|
|
I can go back and add more test but I want to make sure this is what we're looking for? |
There was a problem hiding this comment.
I left a few comments. You can add unit tests for now.
Once parse-community/parse-server#6322 is merged then we can add integration tests.
src/ParseQuery.js
Outdated
| @@ -713,7 +722,8 @@ class ParseQuery { | |||
| const controller = CoreManager.getQueryController(); | |||
| const params = { | |||
| distinct: key, | |||
| where: this._where | |||
| where: this._where, | |||
| hint: this._hint ? this._hint : undefined, | |||
There was a problem hiding this comment.
The reason I did this was because I caused tests to fail because in the constructor this._hint is set to null (like readPreference)... so I can either take setting this._hint as null out of the constructor or keep it like this?
There was a problem hiding this comment.
You will know once you start writing tests.
src/ParseQuery.js
Outdated
|
|
||
| const params = { | ||
| pipeline, | ||
| hint: this._hint ? this._hint : undefined, |
|
@stevestencil Can you give me access to your branch? |
|
@dplewis Done! |
Add support to add hint to Parse.Query (parse-community#1054)
|
Thoughts on documenting this in the guide? |
parse-community/parse-server/issues/6288