Skip to content

Conversation

@Nidal-Bakir
Copy link
Member

@Nidal-Bakir Nidal-Bakir commented Apr 22, 2023

New Pull Request Checklist

Issue Description

Closes: #861

Approach

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • A changelog entry

@parse-github-assistant
Copy link

parse-github-assistant bot commented Apr 22, 2023

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Apr 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8dce6fc) 38.68% compared to head (e0d8276) 38.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #868   +/-   ##
=======================================
  Coverage   38.68%   38.68%           
=======================================
  Files          56       56           
  Lines        3278     3278           
=======================================
  Hits         1268     1268           
  Misses       2010     2010           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Nidal-Bakir Nidal-Bakir changed the title build: Bump the minimum required Dart SDK version to 2.17.0. Upgrade parse_server_sdk to 5.x.x build: Bump the min required Dart SDK version to 2.17.0 Upgrade parse_server_sdk to 5.x.x Apr 22, 2023
@Nidal-Bakir
Copy link
Member Author

The CI checks are falling because parse_server_sdk: 5.0.0 has not been released yet.

@Nidal-Bakir Nidal-Bakir added the state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message label Apr 22, 2023
@Nidal-Bakir Nidal-Bakir changed the title build: Bump the min required Dart SDK version to 2.17.0 Upgrade parse_server_sdk to 5.x.x build: Upgrade parse_server_sdk to 5.x.x May 13, 2023
@Nidal-Bakir
Copy link
Member Author

@mtrezza
The last one!

@mtrezza
Copy link
Member

mtrezza commented May 13, 2023

As you commented in #878 (comment):

But then if anyone uses Flutter SDK will be locked to Dart SDK 4.x.x.

Could we instead just say >=4.0.0 <6.0.0 in #868?

Then #868 would not be a breaking change. I'm not sure if that makes sense given the Flutter / Dart co-dependency. But I guess we'd need to expand our CI to test the Parse Flutter SDK with the Parse Dart SDK 4.x and 5.x. Would it have any benefits for developers if we published a Parse Flutter SDK 5 that is compatible with Parse Dart SDK 4?

@Nidal-Bakir
Copy link
Member Author

Nidal-Bakir commented May 13, 2023

"I'm considering it. The thing is, Pub will always prefer the latest version of a dependency, so even if we define in the constant that we accept Parse SDK >=4.0.0 <6.0.0 and the user is using Flutter 4.1.0, Pub will actually get the latest version, which is 5.0.0. In my understanding, this may not be very clear to set

@Nidal-Bakir
Copy link
Member Author

Because every version of flutter_test from sdk depends on collection 1.17.0 and parse_server_sdk >=5.0.0 depends on collection ^1.17.1, flutter_test from sdk is incompatible with parse_server_sdk >=5.0.0.

And here is the answer to your question :)

@mtrezza
Copy link
Member

mtrezza commented May 13, 2023

Right, I think it would only make sense if a developer would need to define both dependencies, the Parse Dart SDK and the Parse Flutter SDK in an app. Then they could in theory keep using their Parse Dart SDK 4.x while also using the Parse Flutter SDK 5.x. But is that even a realistic scenario?

And here is the answer to your question :)

That doesn't look good. So the Parse Flutter SDK requires at least Flutter 3.10?

@Nidal-Bakir
Copy link
Member Author

Nidal-Bakir commented May 13, 2023

let me run some tests. that is not good at all

@mtrezza
Copy link
Member

mtrezza commented May 13, 2023

It seems strange because flutter_test is just the testing framework, right? So why would the testing framework influence the Parse SDKs compatibility. Maybe we need to change the testing framework then?

@Nidal-Bakir
Copy link
Member Author

If all the CIs resolve the dependency without any errors then we need to lower the collection version to : collection: ^1.16.0

@Nidal-Bakir
Copy link
Member Author

Nidal-Bakir commented May 13, 2023

It seems strange because flutter_test is just the testing framework, right? So why would the testing framework influence the Parse SDKs compatibility. Maybe we need to change the testing framework then?

We can not change the testing framework

This reverts commit b00b884.
@mtrezza
Copy link
Member

mtrezza commented May 13, 2023

parse_server_sdk >=5.0.0 depends on collection ^1.17.1,

Can lower that dependency in the Parse Dart SDK and release a version 5.0.1?

@Nidal-Bakir
Copy link
Member Author

Nidal-Bakir commented May 13, 2023

All the CIs resolve the dependency without any errors when using collection: ^1.16.0. on Dart SDK I test it on my PC also using Flutter 3.3.8 and 3.10. and all good when I changed to collection: ^1.16.0

We need to release Dart 5.0.1 updating the collection dependency to be collection: ^1.16.0.

@mtrezza
Copy link
Member

mtrezza commented May 13, 2023

Great, do you want to open a PR?

@Nidal-Bakir
Copy link
Member Author

Consider it done

@Nidal-Bakir
Copy link
Member Author

can you re-run the CI?

@mtrezza mtrezza changed the title build: Upgrade parse_server_sdk to 5.x.x feat: Upgrade parse_server_sdk to 5.x.x May 14, 2023
@Nidal-Bakir
Copy link
Member Author

yeah, everything is green!

@mtrezza
Copy link
Member

mtrezza commented May 14, 2023

Can this be merged and we can then publish the Flutter 5 release? Or are there any other PRs missing before release?

@Nidal-Bakir
Copy link
Member Author

That's all.

We should be good to go.

@mtrezza mtrezza merged commit 74f45b9 into parse-community:master May 14, 2023
@mtrezza
Copy link
Member

mtrezza commented May 14, 2023

Nice, great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No named parameter with the name 'vsync'.

2 participants