-
-
Notifications
You must be signed in to change notification settings - Fork 214
feat: Upgrade parse_server_sdk to 5.x.x
#868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Upgrade parse_server_sdk to 5.x.x
#868
Conversation
…dependency parse_server_sdk to 5.x.x
Thanks for opening this pull request!
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #868 +/- ##
=======================================
Coverage 38.68% 38.68%
=======================================
Files 56 56
Lines 3278 3278
=======================================
Hits 1268 1268
Misses 2010 2010 ☔ View full report in Codecov by Sentry. |
…dependency parse_server_sdk to 5.x.x
2.17.0. Upgrade parse_server_sdk to 5.x.x2.17.0 Upgrade parse_server_sdk to 5.x.x
|
The CI checks are falling because |
…-Flutter into bump_dart_min_SDK_flutter
…-Flutter into bump_dart_min_SDK_flutter
…Bakir/Parse-SDK-Flutter into bump_dart_min_SDK_flutter
2.17.0 Upgrade parse_server_sdk to 5.x.xparse_server_sdk to 5.x.x
|
@mtrezza |
|
As you commented in #878 (comment):
Could we instead just say Then #868 would not be a breaking change. I'm not sure if that makes sense given the Flutter / Dart co-dependency. But I guess we'd need to expand our CI to test the Parse Flutter SDK with the Parse Dart SDK 4.x and 5.x. Would it have any benefits for developers if we published a Parse Flutter SDK 5 that is compatible with Parse Dart SDK 4? |
|
"I'm considering it. The thing is, Pub will always prefer the latest version of a dependency, so even if we define in the constant that we accept Parse SDK >=4.0.0 <6.0.0 and the user is using Flutter 4.1.0, Pub will actually get the latest version, which is 5.0.0. In my understanding, this may not be very clear to set |
And here is the answer to your question :) |
|
Right, I think it would only make sense if a developer would need to define both dependencies, the Parse Dart SDK and the Parse Flutter SDK in an app. Then they could in theory keep using their Parse Dart SDK 4.x while also using the Parse Flutter SDK 5.x. But is that even a realistic scenario?
That doesn't look good. So the Parse Flutter SDK requires at least Flutter 3.10? |
|
let me run some tests. that is not good at all |
|
It seems strange because |
|
If all the CIs resolve the dependency without any errors then we need to lower the collection version to : collection: ^1.16.0 |
We can not change the testing framework |
This reverts commit b00b884.
Can lower that dependency in the Parse Dart SDK and release a version 5.0.1? |
|
All the CIs resolve the dependency without any errors when using collection: ^1.16.0. on Dart SDK I test it on my PC also using Flutter 3.3.8 and 3.10. and all good when I changed to collection: ^1.16.0 We need to release Dart 5.0.1 updating the collection dependency to be |
|
Great, do you want to open a PR? |
|
Consider it done |
|
can you re-run the CI? |
parse_server_sdk to 5.x.xparse_server_sdk to 5.x.x
|
yeah, everything is green! |
|
Can this be merged and we can then publish the Flutter 5 release? Or are there any other PRs missing before release? |
|
That's all. We should be good to go. |
|
Nice, great work! |
New Pull Request Checklist
Issue Description
Closes: #861
Approach
TODOs before merging