Skip to content

Conversation

@Nidal-Bakir
Copy link
Member

@Nidal-Bakir Nidal-Bakir commented Mar 19, 2023

New Pull Request Checklist

Issue Description

Closes: #854

Approach

Consider the totalResponse from the batch as unsuccessful

// if any request in a batch requests group fails,
// then the overall response will be considered unsuccessful.
totalResponse.success = false;

TODOs before merging

Merge #858 first, then I will add a change log entry with that PR, so we publish two fixes in one version.(4.0.1)

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • A changelog entry

@parse-github-assistant
Copy link

parse-github-assistant bot commented Mar 19, 2023

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Mar 19, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.19 🎉

Comparison is base (bdbc483) 26.51% compared to head (8121f62) 26.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #859      +/-   ##
==========================================
+ Coverage   26.51%   26.71%   +0.19%     
==========================================
  Files          47       47              
  Lines        2904     2905       +1     
==========================================
+ Hits          770      776       +6     
+ Misses       2134     2129       -5     
Impacted Files Coverage Δ
packages/dart/lib/src/objects/parse_object.dart 90.67% <100.00%> (+2.16%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Nidal-Bakir
Copy link
Member Author

Nidal-Bakir commented Mar 19, 2023

The dart test will not pass because the other PR #858 has not been merged yet.

@Nidal-Bakir
Copy link
Member Author

Ready to be merged.

@Nidal-Bakir Nidal-Bakir requested a review from mtrezza March 22, 2023 20:04
@mtrezza mtrezza requested a review from a team March 22, 2023 23:16
mbfakourii
mbfakourii previously approved these changes Mar 23, 2023
@mtrezza mtrezza changed the title fix: The SDK will try to save a ParseObject even if its child ParseObject not saved fix: Attempt to save ParseObject even if one of its nested ParseObject failed to save Mar 23, 2023
@mtrezza mtrezza changed the title fix: Attempt to save ParseObject even if one of its nested ParseObject failed to save fix: Attempt to save ParseObject even if its nested ParseObject failed to save Mar 23, 2023
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Waiting for CI ...

@mtrezza mtrezza merged commit 04f763c into parse-community:master Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The SDK will try to save object even if its child object not saved

3 participants