-
-
Notifications
You must be signed in to change notification settings - Fork 214
fix: Attempt to save ParseObject even if its nested ParseObject failed to save
#859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…onse still considered successful
Thanks for opening this pull request!
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #859 +/- ##
==========================================
+ Coverage 26.51% 26.71% +0.19%
==========================================
Files 47 47
Lines 2904 2905 +1
==========================================
+ Hits 770 776 +6
+ Misses 2134 2129 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
The dart test will not pass because the other PR #858 has not been merged yet. |
|
Ready to be merged. |
ParseObject even if one of its nested ParseObject failed to save
ParseObject even if one of its nested ParseObject failed to saveParseObject even if its nested ParseObject failed to save
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Waiting for CI ...
New Pull Request Checklist
Issue Description
Closes: #854
Approach
Consider the
totalResponsefrom the batch as unsuccessfulTODOs before merging
Merge #858 first, then I will add a change log entry with that PR, so we publish two fixes in one version.(4.0.1)