fix: Attributes `reverse`, `padding`, `physics`, `controller`, `scrollDirection`, `shrinkWrap` not implemented in `ParseLiveGridWidget` #761

pastordee · 2022-06-02T01:01:54Z

New Pull Request Checklist

I am not disclosing a vulnerability.
I am creating this PR in reference to an issue.

Issue Description

Implementation of Scroll Direction and other other parameters/attributes

Related issue: #760

Approach

TODOs before merging

n/a

Add tests
Add changes to documentation (guides, repository pages, in-code descriptions)
A changelog entry

Scroll Direction and other parameters/attributes

parse-github-assistant · 2022-06-02T01:01:56Z

Thanks for opening this pull request!

❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

codecov · 2022-06-02T01:03:11Z

Codecov Report

Patch coverage has no change and project coverage change: -0.08 ⚠️

Comparison is base (366f2dd) 39.11% compared to head (85dc209) 39.04%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #761      +/-   ##
==========================================
- Coverage   39.11%   39.04%   -0.08%     
==========================================
  Files          57       57              
  Lines        3280     3286       +6     
==========================================
  Hits         1283     1283              
- Misses       1997     2003       +6

Impacted Files	Coverage Δ
...ackages/flutter/lib/src/utils/parse_live_grid.dart	`0.00% <0.00%> (ø)`

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

mtrezza · 2022-06-02T19:55:07Z

Is this a bug fix or a feature extension?

fischerscode · 2022-06-02T23:07:24Z

It's a mix, I guess. Maybe more of a bug fix, since the parameters already exist and are just not used (bug).

mtrezza · 2022-06-02T23:16:43Z

Does this PR require any tests or doc changes? @pastordee could you please go through the TODOs at the top?

pastordee · 2022-06-03T01:21:29Z

sorry guys is a bug fix some of the parameters are not used

pastordee · 2022-06-03T01:22:10Z

Does this PR require any tests or doc changes? @pastordee could you please go through the TODOs at the top?

no it doesn't need a test

mtrezza

Can you please add an entry to the flutter changelog?

Since we don't know with which version this PR will be released, you can add this to the top of the changelog:

# Unreleased

### Bug Fixes

* some parameters of `ParseLiveGridWidget` are not used ([#761](https://github.com/parse-community/Parse-SDK-Flutter/pull/761))

no it doesn't need a test

Code coverage reports that the added lines are not covered by tests, so they will decrease coverage. Could you add tests or maybe just expand existing tests?

fischerscode

Since the already existing parameters are only forwarded to the Flutter widget, I don't see what could go wrong with this.

Comment regarding the missing tests:
I think we can merge this without adding tests, since we currently have no tests regarding widgets and in my opinion this PR doe not make the bad situation worse. (Of course I don't think we shouldn't add tests for this parameters when adding tests for the ParseLiveWidgets.)*

mtrezza · 2022-06-03T10:59:28Z

If it takes too much research to add tests for this since we don't test widgets yet at all, then we can merge just to fix the bug. But we will at some point begin to make tests a requirement for merging a PR. Otherwise - by experience - these tests are unlikely to be added in the future and coverage will continue to decrease.

@fischerscode You already approved this PR, but note that it's missing a changelog entry, that is a hard requirement for PRs already.

fischerscode · 2022-06-03T12:12:10Z

it's missing a changelog entry

Sorry, thought we want to create it automatically for the next release.

mtrezza · 2022-06-03T12:42:24Z

Sorry, thought we want to create it automatically for the next release.

I wish! But I think it will take some time to add auto-release to this mono repo.

pastordee · 2022-06-03T12:52:33Z

Sorry, thought we want to create it automatically for the next release.

I wish! But I think it will take some time to add auto-release to this mono repo.

added to the change log

packages/flutter/CHANGELOG.md

packages/flutter/example/linux/flutter/generated_plugin_registrant.h

pastordee · 2022-10-05T13:49:31Z

Sorry, thought we want to create it automatically for the next release.

I wish! But I think it will take some time to add auto-release to this mono repo.

Hi can we approve and merge this please.

packages/flutter/CHANGELOG.md

mtrezza

~~Looks good~~

mtrezza

This PR will be released as flutter version 3.1.4; to merge this, the flutter package version needs to be updated as well.

mbfakourii

@mtrezza
Which parts need to be changed?

pastordee · 2023-05-14T12:25:16Z

Done

mbfakourii · 2023-05-14T12:30:28Z

@pastordee
It seems that you have a conflict

This branch has conflicts that must be resolved

pastordee · 2023-05-16T20:37:44Z

@pastordee It seems that you have a conflict

This branch has conflicts that must be resolved

Sorted

mtrezza

Please add a changelog entry

mbfakourii · 2023-05-20T06:27:30Z

@pastordee I think you should bump the version

mtrezza

Incorrect changelog entry

packages/flutter/CHANGELOG.md

mtrezza

Looks good, just the package version needs to be bumped.

mbfakourii

It looks good

Update parse_live_grid.dart

d363859

Scroll Direction and other parameters/attributes

Update parse_live_grid.dart

57a5ab6

mtrezza linked an issue Jun 2, 2022 that may be closed by this pull request

Use all parameters of ParseLiveGridWidget #760

Closed

3 tasks

fischerscode mentioned this pull request Jun 2, 2022

Scroll Direction #740

Closed

5 tasks

mtrezza changed the title ~~Use all parameters of ParseLiveGridWidget (Scroll Direction)~~ fix: parameters of ParseLiveGridWidget not used Jun 2, 2022

mtrezza changed the title ~~fix: parameters of ParseLiveGridWidget not used~~ fix: some parameters of ParseLiveGridWidget are not used Jun 2, 2022

mtrezza requested a review from a team June 2, 2022 23:20

mtrezza requested changes Jun 3, 2022

View reviewed changes

fischerscode previously approved these changes Jun 3, 2022

View reviewed changes

Added to change log

847b825

pastordee dismissed fischerscode’s stale review via 847b825 June 3, 2022 12:49

mtrezza requested changes Jun 3, 2022

View reviewed changes

packages/flutter/CHANGELOG.md Outdated Show resolved Hide resolved

packages/flutter/example/linux/flutter/generated_plugin_registrant.h Show resolved Hide resolved

Merge branch 'master' into master

b0f4178

mtrezza reviewed Oct 5, 2022

View reviewed changes

packages/flutter/CHANGELOG.md Outdated Show resolved Hide resolved

Update packages/flutter/CHANGELOG.md

166c961

mtrezza approved these changes Oct 5, 2022

View reviewed changes

mtrezza requested changes Oct 5, 2022

View reviewed changes

mbfakourii previously approved these changes Dec 19, 2022

View reviewed changes

mbfakourii mentioned this pull request May 14, 2023

refactor: Increment Flutter SDK compatibility to <4.0.0; add example project #884

Merged

5 tasks

pastordee added 5 commits May 14, 2023 12:48

Update CHANGELOG.md

f86e8d1

Update CHANGELOG.md

afb01c0

Update CHANGELOG.md

dcf6d7d

Update parse_live_list.dart

9f48286

Update CHANGELOG.md

91c9de4

mbfakourii requested a review from a team May 14, 2023 12:29

Merge remote-tracking branch 'upstream/master'

d75eed9

mbfakourii previously approved these changes May 17, 2023

View reviewed changes

Merge branch 'master' into master

2b2a099

mtrezza requested changes May 17, 2023

View reviewed changes

pastordee added 3 commits May 18, 2023 13:02

Merge remote-tracking branch 'upstream/master'

80229af

Merge branch 'master' of https://github.com/pastordee/Parse-SDK-Flutter

8d52e9d

Added changelog entry

5d16bb6

pastordee dismissed mbfakourii’s stale review via 5d16bb6 May 18, 2023 12:17

mtrezza requested changes May 20, 2023

View reviewed changes

packages/flutter/CHANGELOG.md Show resolved Hide resolved

fix changelog entry

26a49bb

mtrezza reviewed May 20, 2023

View reviewed changes

packages/flutter/CHANGELOG.md Outdated Show resolved Hide resolved

remove empty line

d376479

mtrezza previously approved these changes May 20, 2023

View reviewed changes

bump package version

7f00edb

mtrezza dismissed their stale review via 7f00edb May 20, 2023 16:18

mtrezza approved these changes May 20, 2023

View reviewed changes

Merge branch 'master' into master

85dc209

mbfakourii approved these changes May 20, 2023

View reviewed changes

mtrezza merged commit f8942ac into parse-community:master May 20, 2023

Uh oh!

fix: Attributes reverse, padding, physics, controller, scrollDirection, shrinkWrap not implemented in ParseLiveGridWidget #761

fix: Attributes reverse, padding, physics, controller, scrollDirection, shrinkWrap not implemented in ParseLiveGridWidget #761

Uh oh!

Conversation

pastordee commented Jun 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

New Pull Request Checklist

Issue Description

Approach

TODOs before merging

Uh oh!

parse-github-assistant bot commented Jun 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Thanks for opening this pull request!

Uh oh!

codecov bot commented Jun 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mtrezza commented Jun 2, 2022

Uh oh!

fischerscode commented Jun 2, 2022

Uh oh!

mtrezza commented Jun 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pastordee commented Jun 3, 2022

Uh oh!

pastordee commented Jun 3, 2022

Uh oh!

mtrezza left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fischerscode left a comment

Choose a reason for hiding this comment

Uh oh!

mtrezza commented Jun 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fischerscode commented Jun 3, 2022

Uh oh!

mtrezza commented Jun 3, 2022

Uh oh!

pastordee commented Jun 3, 2022

Uh oh!

Uh oh!

Uh oh!

pastordee commented Oct 5, 2022

Uh oh!

Uh oh!

mtrezza left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mtrezza left a comment

Choose a reason for hiding this comment

Uh oh!

mbfakourii left a comment

Choose a reason for hiding this comment

Uh oh!

pastordee commented May 14, 2023

Uh oh!

mbfakourii commented May 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pastordee commented May 16, 2023

Uh oh!

mtrezza left a comment

Choose a reason for hiding this comment

Uh oh!

mbfakourii commented May 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mtrezza left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

fix: Attributes `reverse`, `padding`, `physics`, `controller`, `scrollDirection`, `shrinkWrap` not implemented in `ParseLiveGridWidget` #761

fix: Attributes `reverse`, `padding`, `physics`, `controller`, `scrollDirection`, `shrinkWrap` not implemented in `ParseLiveGridWidget` #761

pastordee commented Jun 2, 2022 •

edited

Loading

parse-github-assistant bot commented Jun 2, 2022 •

edited

Loading

codecov bot commented Jun 2, 2022 •

edited

Loading

mtrezza commented Jun 2, 2022 •

edited

Loading

mtrezza left a comment •

edited

Loading

mtrezza commented Jun 3, 2022 •

edited

Loading

mtrezza left a comment •

edited

Loading

mbfakourii commented May 14, 2023 •

edited

Loading

mbfakourii commented May 20, 2023 •

edited

Loading

mtrezza left a comment •

edited

Loading