Skip to content

expose client destroy #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 25, 2019
Merged

expose client destroy #979

merged 2 commits into from
Oct 25, 2019

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Oct 22, 2019 •
edited
Loading

Exposing destroy method to allow to re-initialize client.

There is an existing test case in which this is used.

Parse-SDK-Android/parse/src/test/java/com/parse/ParseUserTest.java

Lines 1637 to 1638 in 0cfc67e

// Simulate reboot
Parse.destroy();

@mtrezza mtrezza mentioned this pull request Oct 22, 2019
Closed
@mtrezza
Copy link
Member Author

mtrezza commented Oct 25, 2019

@Jawnnypoo what do you think, can we merge this?

Jawnnypoo
Jawnnypoo approved these changes Oct 25, 2019
View reviewed changes
Copy link
Member

@Jawnnypoo Jawnnypoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay

@Jawnnypoo Jawnnypoo merged commit bf882c5 into parse-community:master Oct 25, 2019
@mtrezza mtrezza deleted the expose-client-destroy branch October 26, 2019 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Jawnnypoo Jawnnypoo Jawnnypoo approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtrezza @Jawnnypoo