Skip to content

Set the required internet/network permissions in the SDK #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2017

Conversation

hermanliang
Copy link
Contributor

State INTERNET and ACCESS_NETWORK_STATE use-permission in the SDK level.
Therefore, no longer need to be declared in App AndroidManifest.xml.

@codecov
Copy link

codecov bot commented May 16, 2017

Codecov Report

Merging #666 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #666   +/-   ##
=========================================
  Coverage     52.86%   52.86%           
  Complexity     1676     1676           
=========================================
  Files           131      131           
  Lines         10150    10150           
  Branches       1408     1408           
=========================================
  Hits           5366     5366           
  Misses         4341     4341           
  Partials        443      443

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bee0310...abec87b. Read the comment docs.

@natario1
Copy link
Contributor

Makes sense to me!

@Jawnnypoo Jawnnypoo self-requested a review May 16, 2017 13:44
@Jawnnypoo
Copy link
Member

Sounds good! People usually add these right away to a project anyways, so should be nice for those that don't 👍

@rogerhu
Copy link
Contributor

rogerhu commented May 16, 2017

With AAR as the default format this will also help. :)

@rogerhu rogerhu merged commit 7e51014 into parse-community:master May 17, 2017
@hermanliang hermanliang deleted the default-use-permissions branch May 22, 2017 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants